lib/compiler/implementation/ssa/bailout.dart - Issue 10116023: Don't rely on any speculative type in the bailout version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/bailout.dart

Issue 10116023: Don't rely on any speculative type in the bailout version. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/ssa/bailout.dart

diff --git a/lib/compiler/implementation/ssa/bailout.dart b/lib/compiler/implementation/ssa/bailout.dart

index 1df10d158e8420518cef115a02a8e3d55c46cc23..9c96cc03a029ddc6bc26cc4f150017c2893f8b73 100644

--- a/lib/compiler/implementation/ssa/bailout.dart

+++ b/lib/compiler/implementation/ssa/bailout.dart

@@ -286,7 +286,8 @@ class SsaTypeGuardBuilder extends HBaseVisitor implements OptimizationPhase {

int state = 1;

capturedEnvironments.forEach((HInstruction instruction, Environment env) {

List<HInstruction> inputs = env.buildAndSetLast(instruction);

- HTypeGuard guard = new HTypeGuard(state++, inputs);

+ HTypeGuard guard =

+ new HTypeGuard(instruction.propagatedType, state++, inputs);

work.guards.add(guard);

instruction.block.rewrite(instruction, guard);

HInstruction insertionPoint = (instruction is HPhi)

« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »