We must use the original element and not the default implementation element when checking if the co…

We must use the original element and not the default implementation element when checking if the constructor is the List constructor.
Committed: https://code.google.com/p/dart/source/detail?r=6748

[floitsch, 2012-04-19 10:50:32]

LGTM.

https://chromiumcodereview.appspot.com/10113007/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10113007/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:2158: } else if
(element.isFactoryConstructor()
Since we need to look at the original non-forwarded element anyways, let's only
look at that one.
Add a comment why.
And I don't think we shouldn't care if it is a constructor or a factory. In the
test-mockup it would be a factory, and in the actual implementation it would
probably be a constructor (since that's the kind in the interface).

[ngeoffray, 2012-04-19 16:17:52]

https://chromiumcodereview.appspot.com/10113007/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10113007/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:2158: } else if
(element.isFactoryConstructor()
On 2012/04/19 10:50:32, floitsch wrote:
> Since we need to look at the original non-forwarded element anyways, let's
only
> look at that one.
> Add a comment why.
> And I don't think we shouldn't care if it is a constructor or a factory. In
the
> test-mockup it would be a factory, and in the actual implementation it would
> probably be a constructor (since that's the kind in the interface).

Done.