We must use the original element and not the default implementation element when checking if the co…

lib/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 2137 matching lines @@
                                                     element, inputs);
       if (!succeeded) {
         // TODO(ngeoffray): Match the VM behavior and throw an
         // exception at runtime.
         compiler.cancel('Unimplemented non-matching static call', node: node);
       }
       HType type = HType.UNKNOWN;
       if (element.isGenerativeConstructor()) {
         ClassElement cls = element.enclosingElement;
         type = new HNonPrimitiveType(cls.type);
       } else if (element.isFactoryConstructor()

[floitsch, 2012/04/19 10:50:32]

Since we need to look at the original non-forwarded element anyways, let's only
look at that one.
Add a comment why.
And I don't think we shouldn't care if it is a constructor or a factory. In the
test-mockup it would be a factory, and in the actual implementation it would
probably be a constructor (since that's the kind in the interface).

[ngeoffray, 2012/04/19 16:17:52]

Done.

-                 && element === compiler.listClass) {
+                 && elements[node].enclosingElement === compiler.listClass) {
         type = HType.MUTABLE_ARRAY;
       }
       push(new HInvokeStatic(selector, inputs, type));
     } else {
       if (element.kind == ElementKind.GETTER) {
         target = new HInvokeStatic(Selector.GETTER, inputs);
         add(target);
         inputs = <HInstruction>[target];
       }
       addDynamicSendArgumentsToList(node, inputs);
@@ skipping 937 matching lines @@
                                         false,
                                         <HInstruction>[target, input]));
     return builder.pop();
   }
 
   HInstruction result() {
     flushLiterals();
     return prefix;
   }
 }