Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10107027: Generate proper wrapper types for ActiveDOMObjects. (Closed)

Created:
8 years, 8 months ago by podivilov
Modified:
8 years, 8 months ago
Reviewers:
Anton Muhin, antonm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Generate proper wrapper types for ActiveDOMObjects. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6688

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M lib/dom/scripts/systemnative.py View 1 chunk +8 lines, -2 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 8 months ago (2012-04-17 17:35:59 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/10107027/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10107027/diff/1/lib/dom/scripts/systemnative.py#newcode842 lib/dom/scripts/systemnative.py:842: type = 'Object' why it's not DOM{Object,Node} any more?
8 years, 8 months ago (2012-04-17 17:42:06 UTC) #2
podivilov
https://chromiumcodereview.appspot.com/10107027/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10107027/diff/1/lib/dom/scripts/systemnative.py#newcode842 lib/dom/scripts/systemnative.py:842: type = 'Object' On 2012/04/17 17:42:06, antonmuhin wrote: > ...
8 years, 8 months ago (2012-04-18 08:46:53 UTC) #3
Anton Muhin
8 years, 8 months ago (2012-04-18 09:01:06 UTC) #4 
LGTM

https://chromiumcodereview.appspot.com/10107027/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10107027/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:842: type = 'Object'
ok, thanks

On 2012/04/18 08:46:53, podivilov wrote:
> On 2012/04/17 17:42:06, antonmuhin wrote:
> > why it's not DOM{Object,Node} any more?
> 
> For brevity. These type names are declared in DartDOMWrapper class, which
> already has "DOM" in its name, and are obviously related to DOM.

Powered by Google App Engine
This is Rietveld 408576698