Issue 10106016: Remove warning for using a factory constructor on an abstract class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10106016: Remove warning for using a factory constructor on an abstract class. (Closed)

Created:
8 years, 8 months ago by zundel

Modified:
8 years, 8 months ago

Reviewers:
ahe, scheglov

CC:
reviews_dartlang.org, danrubel, Brian Wilkerson

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove warning for using a factory constructor on an abstract class. http://code.google.com/p/dart/issues/detail?id=2282 Committed: https://code.google.com/p/dart/source/detail?r=6619

Patch Set 1 : # #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -15 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	5 chunks	+6 lines, -7 lines	0 comments	Download
A	tests/language/src/AbstractFactoryConstructorTest.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zundel

On 2012/04/17 09:29:44, ahe wrote: > lgtm > > Thank you, Eric! @Konstantin, I went ...

8 years, 8 months ago (2012-04-17 09:32:32 UTC) #3

scheglov

8 years, 8 months ago (2012-04-17 13:06:19 UTC) #4

LGTM

> @Konstantin, I went ahead and submitted so the dart2js developers could grab
the
> continuous build of the editor today and get around this issue.

  Yes, as you may be remember I've tried to remove this warning, but at that
time spec author requested to keep it.

Expand Messages | Collapse Messages