compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 10106016: Remove warning for using a factory constructor on an abstract class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10106016: Remove warning for using a factory constructor on an abstract class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: # Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index 4a2f0ca3b016362bd4e519f080336b54c1e20478..7decd166a5805cefc8bfe105fab7e8b892e6df27 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -1218,12 +1218,8 @@ public class TypeAnalyzer implements DartCompilationPhase {

} else {

ClassElement cls = (ClassElement) constructorElement.getEnclosingElement();

// Add warning for instantiating abstract class.

- if (cls.isAbstract()) {

- ErrorCode errorCode =

- constructorElement.getModifiers().isFactory()

- ? TypeErrorCode.INSTANTIATION_OF_ABSTRACT_CLASS_USING_FACTORY

- : TypeErrorCode.INSTANTIATION_OF_ABSTRACT_CLASS;

- typeError(typeName, errorCode, cls.getName());

+ if (cls.isAbstract() && !constructorElement.getModifiers().isFactory()) {

+ typeError(typeName, TypeErrorCode.INSTANTIATION_OF_ABSTRACT_CLASS, cls.getName());

} else {

List<Element> unimplementedMembers = findUnimplementedMembers(cls);

if (unimplementedMembers.size() > 0) {