Issue 10081004: Remove frog dependencies from lib/compiler.

Issue 10081004: Remove frog dependencies from lib/compiler. (Closed)

Created:
8 years, 8 months ago by kasperl

Modified:
8 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove frog dependencies from lib/compiler. Start importing the URI library using dart:uri rather than dotting our way to the right directory in lib. R=ahe@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6511

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add TODO. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -164 lines)			Patch
D	frog/frog.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download
A +	frog/frog_leg.dart	View		4 chunks	+6 lines, -7 lines	0 comments	Download
M	frog/frogc.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/tests/leg/src/compiler_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/tests/leg/src/mock_compiler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/tests/leg/src/parser_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/world.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/compiler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/apiimpl.dart	View		5 chunks	+14 lines, -15 lines	0 comments	Download
M	lib/compiler/implementation/dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/enqueue.dart	View		1 chunk	+13 lines, -11 lines	0 comments	Download
D	lib/compiler/implementation/frog_leg.dart	View		1 chunk	+0 lines, -107 lines	0 comments	Download
M	lib/compiler/implementation/leg.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/native_handler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/scannerlib.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/script.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/utils/src/DummyCompilerTest.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! Thanks for cleaning up the dart:uri imports. https://chromiumcodereview.appspot.com/10081004/diff/1/frog/frog_leg.dart File frog/frog_leg.dart (right): https://chromiumcodereview.appspot.com/10081004/diff/1/frog/frog_leg.dart#newcode53 frog/frog_leg.dart:53: Map<String, ...

8 years, 8 months ago (2012-04-13 11:50:55 UTC) #2

kasperl

8 years, 8 months ago (2012-04-13 11:59:53 UTC) #3

https://chromiumcodereview.appspot.com/10081004/diff/1/lib/compiler/implement...
File lib/compiler/implementation/enqueue.dart (left):

https://chromiumcodereview.appspot.com/10081004/diff/1/lib/compiler/implement...
lib/compiler/implementation/enqueue.dart:114: void
onRegisterInstantiatedClass(ClassElement cls) => measure(() {
On 2012/04/13 11:50:55, ahe wrote:
> I guess you don't like this style?

The analyzer doesn't like the style. I'll file a bug report. Also, I prefer to
keep the different methods here consistent.

https://chromiumcodereview.appspot.com/10081004/diff/1/lib/compiler/implement...
File lib/compiler/implementation/script.dart (left):

https://chromiumcodereview.appspot.com/10081004/diff/1/lib/compiler/implement...
lib/compiler/implementation/script.dart:6: final /* frog.SourceFile */ file;
On 2012/04/13 11:50:55, ahe wrote:
> I'd like to get a type on this. Could you add a todo?

I'll add a TODO here. We cannot use SourceFile right now, because we also use
MockFile sometimes. That is definitely fixable.

Expand Messages | Collapse Messages