lib/compiler/implementation/script.dart - Issue 10081004: Remove frog dependencies from lib/compiler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: lib/compiler/implementation/script.dart

Issue 10081004: Remove frog dependencies from lib/compiler. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 class Script {	5 class Script {

6 final /* frog.SourceFile */ file;	6 final file;
ahe 2012/04/13 11:50:55 I'd like to get a type on this. Could you add a to I'd like to get a type on this. Could you add a todo? kasperl 2012/04/13 11:59:53 I'll add a TODO here. We cannot use SourceFile rig Show quoted text On 2012/04/13 11:50:55, ahe wrote: > I'd like to get a type on this. Could you add a todo? I'll add a TODO here. We cannot use SourceFile right now, because we also use MockFile sometimes. That is definitely fixable.
7 final Uri uri;	7 final Uri uri;

8 Script(this.uri, this.file);	8 Script(this.uri, this.file);

9	9

10 String get text() => (file === null) ? null : file.text;	10 String get text() => (file === null) ? null : file.text;

11 String get name() => (file === null) ? null : file.filename;	11 String get name() => (file === null) ? null : file.filename;

12 }	12 }

OLD	NEW