Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10052030: Address review comments. (Closed)

Created:
8 years, 8 months ago by siva
Modified:
8 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Address review comments. Committed: https://code.google.com/p/dart/source/detail?r=6667

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M runtime/vm/os_win.cc View 1 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years, 8 months ago (2012-04-11 23:11:50 UTC) #1
Ivan Posva
LGTM -ip https://chromiumcodereview.appspot.com/10052030/diff/1/runtime/vm/os_win.cc File runtime/vm/os_win.cc (right): https://chromiumcodereview.appspot.com/10052030/diff/1/runtime/vm/os_win.cc#newcode163 runtime/vm/os_win.cc:163: #ifndef va_copy The only question I have ...
8 years, 8 months ago (2012-04-17 18:54:44 UTC) #2
siva
8 years, 8 months ago (2012-04-17 23:55:00 UTC) #3 
https://chromiumcodereview.appspot.com/10052030/diff/1/runtime/vm/os_win.cc
File runtime/vm/os_win.cc (right):

https://chromiumcodereview.appspot.com/10052030/diff/1/runtime/vm/os_win.cc#n...
runtime/vm/os_win.cc:163: #ifndef va_copy
Will move it once we run into that issue again. For now I have added a TODO
here.

On 2012/04/17 18:54:44, Ivan Posva wrote:
> The only question I have is whether we should move the definition of va_copy
> into globals.h as we had uses for it in the past and sort of worked around it.

Powered by Google App Engine
This is Rietveld 408576698