Address review comments.

runtime/vm/os_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/os.h"
 
 #include <time.h>
 
 #include "platform/assert.h"
 
@@ skipping 142 matching lines @@
 
 int OS::SNPrint(char* str, size_t size, const char* format, ...) {
   va_list args;
   va_start(args, format);
   int retval = VSNPrint(str, size, format, args);
   va_end(args);
   return retval;
 }
 
 
+#ifndef va_copy

[Ivan Posva, 2012/04/17 18:54:44]

The only question I have is whether we should move the definition of va_copy
into globals.h as we had uses for it in the past and sort of worked around it.

[siva, 2012/04/17 23:55:00]

Will move it once we run into that issue again. For now I have added a TODO
here.

On 2012/04/17 18:54:44, Ivan Posva wrote:

+#define va_copy(dst, src) (memmove(&(dst), &(src), sizeof(dst)))
+#endif  /* va_copy */
+
+
 int OS::VSNPrint(char* str, size_t size, const char* format, va_list args) {
   if (str == NULL || size == 0) {
     return _vscprintf(format, args);
   }
-  int written =_vsnprintf(str, size, format, args);
+  va_list args_copy;
+  va_copy(args_copy, args);
+  int written =_vsnprintf(str, size, format, args_copy);
+  va_end(args_copy);
   if (written < 0) {
     // _vsnprintf returns -1 if the number of characters to be written is
     // larger than 'size', so we call _vscprintf which returns the number
     // of characters that would have been written.
-    written = _vscprintf(format, args);
+    va_list args_retry;
+    va_copy(args_retry, args);
+    written = _vscprintf(format, args_retry);
+    va_end(args_retry);
   }
   // Make sure to zero-terminate the string if the output was
   // truncated or if there was an error.
   if (written >= size) {
     str[size - 1] = '\0';
   }
   return written;
 }
 
 
@@ skipping 24 matching lines @@
 void OS::Abort() {
   abort();
 }
 
 
 void OS::Exit(int code) {
   exit(code);
 }
 
 }  // namespace dart