Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2253)

Unified Diff: lib/compiler/implementation/native_emitter.dart

Issue 10052020: Reduce size by emitting $.foo instead of Isolate.prototype.foo. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/namer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/native_emitter.dart
diff --git a/lib/compiler/implementation/native_emitter.dart b/lib/compiler/implementation/native_emitter.dart
index f5a8a6db88f3822b5f53a659d3a5318441959659..ddc2f50d420893d905ea8b997260eaf0ca4dcd84 100644
--- a/lib/compiler/implementation/native_emitter.dart
+++ b/lib/compiler/implementation/native_emitter.dart
@@ -302,7 +302,7 @@ class NativeEmitter {
bool isSupertypeOfNativeClass(Element element) {
if (element.isTypeVariable()) {
- compiler.cancel("Is check for type variable", element: work.element);
+ compiler.cancel("Is check for type variable", element: element);
return false;
}
if (element.computeType(compiler) is FunctionType) return false;
@@ -322,12 +322,12 @@ class NativeEmitter {
return isSupertypeOfNativeClass(element);
}
- void emitIsChecks(StringBuffer buffer) {
+ void emitIsChecks(StringBuffer checkBuffer) {
for (Element type in compiler.universe.isChecks) {
if (!requiresNativeIsCheck(type)) continue;
String name = compiler.namer.operatorIs(type);
- buffer.add("$defPropName(Object.prototype, '$name', ");
- buffer.add('function() { return false; });\n');
+ checkBuffer.add("$defPropName(Object.prototype, '$name', ");
+ checkBuffer.add('function() { return false; });\n');
}
}
« no previous file with comments | « lib/compiler/implementation/namer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698