Socket.available should never return a negative value.

Socket.available should never return a negative value.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=6399

[Mads Ager (google), 2012-04-11 07:20:23]

https://chromiumcodereview.appspot.com/10052007/diff/1/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://chromiumcodereview.appspot.com/10052007/diff/1/runtime/bin/socket.cc#...
runtime/bin/socket.cc:43: if (available < 0) available = 0;
I think we need to handle this differently. An error occurred if available is
less than 0. How about getting the OS error and propagating that to the dart
code in socket_impl.dart. If we get an OSError object back we report that error
on the socket error handler and return 0 from available?

[Anders Johnsen, 2012-04-11 07:25:06]

https://chromiumcodereview.appspot.com/10052007/diff/1/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://chromiumcodereview.appspot.com/10052007/diff/1/runtime/bin/socket.cc#...
runtime/bin/socket.cc:43: if (available < 0) available = 0;
On 2012/04/11 07:20:23, Mads Ager wrote:
> I think we need to handle this differently. An error occurred if available is
> less than 0. How about getting the OS error and propagating that to the dart
> code in socket_impl.dart. If we get an OSError object back we report that
error
> on the socket error handler and return 0 from available?

Agreed, this is a lot better. I've updated as suggested.

[Mads Ager (google), 2012-04-11 08:41:12]

lgtm