Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10041033: Improve tracer output for bailouts. (Closed)

Created:
8 years, 8 months ago by floitsch
Modified:
8 years, 8 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improve tracer output for bailouts. Committed: https://code.google.com/p/dart/source/detail?r=6737

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M lib/compiler/implementation/ssa/tracer.dart View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
8 years, 8 months ago (2012-04-18 17:28:46 UTC) #1
kasperl
LGTM. https://chromiumcodereview.appspot.com/10041033/diff/1/lib/compiler/implementation/ssa/tracer.dart File lib/compiler/implementation/ssa/tracer.dart (right): https://chromiumcodereview.appspot.com/10041033/diff/1/lib/compiler/implementation/ssa/tracer.dart#newcode426 lib/compiler/implementation/ssa/tracer.dart:426: return result.toString(); I kind of like doing this ...
8 years, 8 months ago (2012-04-19 06:45:57 UTC) #2
floitsch
8 years, 8 months ago (2012-04-19 12:06:27 UTC) #3
https://chromiumcodereview.appspot.com/10041033/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/tracer.dart (right):

https://chromiumcodereview.appspot.com/10041033/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/tracer.dart:426: return result.toString();
On 2012/04/19 06:45:57, kasperl wrote:
> I kind of like doing this in this way:
> 
>    var on = node.isOn ? "on" : "off";
>    var id = temporaryId(node.guarded);
>    return "TypeGuard($on): $id is $type env: $buffer";
> 
> and get rid of the first result.add() calls. WDYT? I think it makes the format
> easier to grok.

Done.

Powered by Google App Engine
This is Rietveld 408576698