Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 10035058: Throw a type error in production mode when the type of the type test is not (Closed)

Created:
8 years, 8 months ago by regis
Modified:
8 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Throw a type error in production mode when the type of the type test is not declared (issue 2571). Add test. Delete bad negative test now covered by new test. Update status files of different compilers. Committed: https://code.google.com/p/dart/source/detail?r=6754

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -33 lines) Patch
M runtime/bin/builtin.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M tests/language/language-leg.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/Instanceof3Test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
D tests/language/src/IsNotClass3NegativeTest.dart View 1 2 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
8 years, 8 months ago (2012-04-19 15:55:17 UTC) #1
srdjan
8 years, 8 months ago (2012-04-19 16:56:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698