Throw a type error in production mode when the type of the type test is not

runtime/vm/class_finalizer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/class_finalizer.h"
 
 #include "vm/flags.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
 #include "vm/longjump.h"
@@ skipping 1252 matching lines @@
 
 
 void ClassFinalizer::FinalizeMalformedType(const Error& prev_error,
                                            const Class& cls,
                                            const Type& type,
                                            FinalizationKind finalization,
                                            const char* format, ...) {
   va_list args;
   va_start(args, format);
   LanguageError& error = LanguageError::Handle();
-  if ((finalization == kFinalizeWellFormed) || FLAG_enable_type_checks) {
+  if (FLAG_enable_type_checks ||
+      !type.HasResolvedTypeClass() ||
+      (finalization == kFinalizeWellFormed)) {
     const Script& script = Script::Handle(cls.script());
     if (prev_error.IsNull()) {
       error ^= Parser::FormatError(
           script, type.token_index(), "Error", format, args);
     } else {
       error ^= Parser::FormatErrorWithAppend(
           prev_error, script, type.token_index(), "Error", format, args);
     }
     if (finalization == kFinalizeWellFormed) {
       ReportError(error);
     }
   }
-  if (FLAG_enable_type_checks) {
-    // In checked mode, mark type as malformed.
+  if (FLAG_enable_type_checks || !type.HasResolvedTypeClass()) {
+    // In check mode, always mark the type as malformed.
+    // In production mode, mark the type as malformed only if its type class is
+    // not resolved.
     type.set_malformed_error(error);
   } else {
-     // In production mode, replace malformed type with Dynamic type.
-    type.set_type_class(Class::Handle(Object::dynamic_class()));
+     // In production mode, do not mark the type with a resolved type class as
+     // malformed, but make it raw.
+    ASSERT(type.HasResolvedTypeClass());
     type.set_arguments(AbstractTypeArguments::Handle());
   }
   if (!type.IsFinalized()) {
     type.set_is_finalized();
     // Do not canonicalize malformed types, since they may not be resolved.
   } else {
     // The only case where the malformed type was already finalized is when its
     // type arguments are not within bounds. In that case, we have a prev_error.
     ASSERT(!prev_error.IsNull());
   }
@@ skipping 20 matching lines @@
 void ClassFinalizer::ReportError(const char* format, ...) {
   va_list args;
   va_start(args, format);
   const Error& error = Error::Handle(
       Parser::FormatError(Script::Handle(), -1, "Error", format, args));
   va_end(args);
   ReportError(error);
 }
 
 }  // namespace dart