Issue 10034002: Selenium / Dartium cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10034002: Selenium / Dartium cleanup (Closed)

Created:
8 years, 8 months ago by vsm

Modified:
8 years, 8 months ago

Reviewers:
Emily Fortuna, sra, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Selenium / Dartium cleanup - Set client.status - Enable executable path to be passed into test.dart (needed for dartium bots to invoke) Committed: https://code.google.com/p/dart/source/detail?r=6387

Patch Set 2 : Remove string+ #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
M	client/tests/client/client.status	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm https://chromiumcodereview.appspot.com/10034002/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10034002/diff/1/tools/testing/dart/test_suite.dart#newcode792 tools/testing/dart/test_suite.dart:792: return '$dartDir/client/tests/dartium/Chromium.app/Contents/' + No +. juxtaposition now works.

8 years, 8 months ago (2012-04-10 22:17:49 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 10034002: Selenium / Dartium cleanup (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove string+ #

Messages