Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: tools/testing/dart/test_options.dart

Issue 10034002: Selenium / Dartium cleanup (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove string+ Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/client/client.status ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index a9d419a9cd0261123a777a4cb4c6d9d40bb467f2..8dad0ce5f915713a4beac977cfec877f8378a10b 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -415,6 +415,14 @@ is 'dart file.dart' and you specify special command
print("Error: shard index is ${config['shard']} out of " +
"${config['shards']} shards");
}
+ if (config['runtime'] == 'dartium' && config['compiler'] == 'none' &&
+ config['checked']) {
+ // TODO(vsm): Set the DART_FLAGS environment appropriately when
+ // invoking Selenium to support checked mode. It's not clear
+ // the current selenium API supports this.
+ isValid = false;
+ print("Warning: checked mode is not yet supported for dartium tests.");
+ }
return isValid;
}
« no previous file with comments | « client/tests/client/client.status ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698