Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 10032027: Add remoteHost to Socket. (Closed)

Created:
8 years, 8 months ago by Anders Johnsen
Modified:
8 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add remoteHost to Socket. This is merging the native calls into one, GetRemotePeer, thus eliminating a potentiel extra call to getpeername. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6353

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed then need for allocating buffer in heap. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -18 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/socket.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M runtime/bin/socket.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/socket_impl.dart View 2 chunks +12 lines, -2 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 2 chunks +12 lines, -4 lines 0 comments Download
A tests/standalone/src/io/SocketInfoTest.dart View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
New attempt at adding remoteHost to Socket, based on feedback.
8 years, 8 months ago (2012-04-10 09:24:26 UTC) #1
Søren Gjesse
lgtm https://chromiumcodereview.appspot.com/10032027/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://chromiumcodereview.appspot.com/10032027/diff/1/runtime/bin/socket.cc#newcode163 runtime/bin/socket.cc:163: const char *host = NULL; How about char ...
8 years, 8 months ago (2012-04-10 11:32:40 UTC) #2
Anders Johnsen
Like so? :)
8 years, 8 months ago (2012-04-10 12:09:05 UTC) #3
Søren Gjesse
8 years, 8 months ago (2012-04-10 12:12:02 UTC) #4
lgtm

Exactly

Powered by Google App Engine
This is Rietveld 408576698