Add remoteHost to Socket.

runtime/bin/socket.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/socket.h"
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 #include "platform/thread.h"
 #include "platform/utils.h"
@@ skipping 135 matching lines @@
   intptr_t port = Socket::GetPort(socket);
   if (port > 0) {
     Dart_SetReturnValue(args, Dart_NewInteger(port));
   } else {
     Dart_SetReturnValue(args, DartUtils::NewDartOSError());
   }
   Dart_ExitScope();
 }
 
 
-void FUNCTION_NAME(Socket_GetRemotePort)(Dart_NativeArguments args) {
+void FUNCTION_NAME(Socket_GetRemotePeer)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t socket =
       DartUtils::GetIntegerField(Dart_GetNativeArgument(args, 0),
                                  DartUtils::kIdFieldName);
   OSError os_error;
-  intptr_t port = Socket::GetRemotePort(socket);
-  if (port > 0) {
-    Dart_SetReturnValue(args, Dart_NewInteger(port));
+  intptr_t port = 0;
+  const char *host = NULL;

[Søren Gjesse, 2012/04/10 11:32:41]

How about

char host[INET_ADDRSTRLEN];

here? Then you don't need the allocation/deallocation.

Of cause you need to define a platform independent INET_ADDRSTRLEN here. Could
be named DART_INET_ADDRSTRLEN and you can assert that DART_INET_ADDRSTRLEN >=
INET_ADDRSTRLEN in all platform specific files.

+  if (Socket::GetRemotePeer(socket, &host, &port)) {
+    Dart_Handle list = Dart_NewList(2);
+    Dart_ListSetAt(list, 0, Dart_NewString(host));
+    Dart_ListSetAt(list, 1, Dart_NewInteger(port));
+    Dart_SetReturnValue(args, list);
+    delete[] host;
   } else {
     Dart_SetReturnValue(args, DartUtils::NewDartOSError());
   }
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Socket_GetError)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t socket =
@@ skipping 132 matching lines @@
   Dart_EnterScope();
   Dart_SetReturnValue(args, Dart_Null());
   Dart_Port service_port = Socket::GetServicePort();
   if (service_port != kIllegalPort) {
     // Return a send port for the service port.
     Dart_Handle send_port = Dart_NewSendPort(service_port);
     Dart_SetReturnValue(args, send_port);
   }
   Dart_ExitScope();
 }