Issue 10031029: Double the timeout for JUnit tests in dartc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10031029: Double the timeout for JUnit tests in dartc (Closed)

Created:
8 years, 8 months ago by zundel

Modified:
8 years, 8 months ago

Reviewers:
Mads Ager (google), Bill Hesse, William Hesse, Mads Ager (chromium)

CC:
reviews_dartlang.org, Brian Wilkerson, scheglov, danrubel

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Double the timeout for JUnit tests in dartc Committed: https://code.google.com/p/dart/source/detail?r=6350

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+9 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zundel

We are starting to see timeouts on the dartc junit tests on the builder. I ...

8 years, 8 months ago (2012-04-10 04:30:13 UTC) #1

Bill Hesse

https://chromiumcodereview.appspot.com/10031029/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/10031029/diff/1/tools/testing/dart/test_suite.dart#newcode1134 tools/testing/dart/test_suite.dart:1134: Map updatedConfiguration = new Map(); Why not new Map.from(configuration)?

8 years, 8 months ago (2012-04-10 10:50:56 UTC) #3

zundel

8 years, 8 months ago (2012-04-10 11:16:29 UTC) #4

On 2012/04/10 10:50:56, Bill Hesse wrote:
>
https://chromiumcodereview.appspot.com/10031029/diff/1/tools/testing/dart/tes...
> File tools/testing/dart/test_suite.dart (right):
> 
>
https://chromiumcodereview.appspot.com/10031029/diff/1/tools/testing/dart/tes...
> tools/testing/dart/test_suite.dart:1134: Map updatedConfiguration = new Map();
> Why not new Map.from(configuration)?

Oh, I was looking for something like that but didn't see it.

Expand Messages | Collapse Messages