Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 10031029: Double the timeout for JUnit tests in dartc (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index fa06f77db9a157e6b77b55d65faaa6d671bbfd41..7c8b7472d4be0f8213af039bbe3e82f06f4b06be 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1128,10 +1128,17 @@ class JUnitTestSuite implements TestSuite {
dartDir + '/tools/test.py',
'org.junit.runner.JUnitCore'];
args.addAll(testClasses);
-
+
+ // Lengthen the timeout for JUnit tests. It is normal for them
+ // to run for a few minutes.
+ Map updatedConfiguration = new Map();
Bill Hesse 2012/04/10 10:50:56 Why not new Map.from(configuration)?
+ configuration.forEach((key, value) {
+ updatedConfiguration[key] = value;
+ });
+ updatedConfiguration['timeout'] *= 2;
doTest(new TestCase(suiteName,
[new Command('java', args)],
- configuration,
+ updatedConfiguration,
completeHandler,
new Set<String>.from([PASS])));
doDone();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698