Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 10030001: Resubmit change 6302 after fixing the compiler warning on older GCC compiler versions: (Closed)

Created:
8 years, 8 months ago by siva
Modified:
8 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Resubmit change 6302 after fixing the compiler warning on older GCC compiler versions: Change 6302 description: - Wire the stack frame iterator to use stack maps for traversing objects if there are stack maps in the code object. If there are no stack maps it still does the old style stack frame traversal between fp and sp looking for tagged pointers. - Added a mechanism to be able to iterate over the code space and look for a particular object. Committed: https://code.google.com/p/dart/source/detail?r=6331

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -134 lines) Patch
M vm/bitmap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M vm/bitmap_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M vm/code_descriptors.h View 1 chunk +2 lines, -1 line 0 comments Download
M vm/code_descriptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M vm/code_descriptors_test.cc View 5 chunks +89 lines, -8 lines 0 comments Download
M vm/code_generator.cc View 2 chunks +1 line, -4 lines 0 comments Download
M vm/code_index_table_test.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M vm/compiler.cc View 6 chunks +0 lines, -12 lines 0 comments Download
M vm/debugger.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M vm/disassembler_ia32.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M vm/heap.h View 1 chunk +9 lines, -0 lines 0 comments Download
M vm/heap.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M vm/object.h View 5 chunks +14 lines, -6 lines 0 comments Download
M vm/object.cc View 8 chunks +46 lines, -43 lines 0 comments Download
M vm/pages.h View 2 chunks +4 lines, -0 lines 0 comments Download
M vm/pages.cc View 2 chunks +38 lines, -0 lines 0 comments Download
M vm/raw_object.h View 8 chunks +17 lines, -0 lines 0 comments Download
M vm/raw_object.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M vm/runtime_entry_test.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M vm/stack_frame.h View 2 chunks +19 lines, -0 lines 0 comments Download
M vm/stack_frame.cc View 4 chunks +81 lines, -20 lines 2 comments Download
M vm/stack_frame_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M vm/unit_test.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M vm/visitor.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years, 8 months ago (2012-04-09 17:57:54 UTC) #1
srdjan
LGTM https://chromiumcodereview.appspot.com/10030001/diff/1/vm/stack_frame.cc File vm/stack_frame.cc (right): https://chromiumcodereview.appspot.com/10030001/diff/1/vm/stack_frame.cc#newcode65 vm/stack_frame.cc:65: // be able to resuse the handle based ...
8 years, 8 months ago (2012-04-09 18:04:56 UTC) #2
siva
8 years, 8 months ago (2012-04-09 18:17:32 UTC) #3
https://chromiumcodereview.appspot.com/10030001/diff/1/vm/stack_frame.cc
File vm/stack_frame.cc (right):

https://chromiumcodereview.appspot.com/10030001/diff/1/vm/stack_frame.cc#newc...
vm/stack_frame.cc:65: // be able to resuse the handle based code and avoid
having to add
On 2012/04/09 18:04:56, srdjan wrote:
> resuse -> reuse

Done.

Powered by Google App Engine
This is Rietveld 408576698