Resubmit change 6302 after fixing the compiler warning on older GCC compiler versions:

vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
 #include "vm/code_generator.h"
-#include "vm/code_index_table.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
 #include "vm/debuginfo.h"
 #include "vm/double_conversion.h"
 #include "vm/exceptions.h"
 #include "vm/growable_array.h"
 #include "vm/heap.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/runtime_entry.h"
 #include "vm/scopes.h"
+#include "vm/stack_frame.h"
 #include "vm/timer.h"
 #include "vm/unicode.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, generate_gdb_symbols, false,
     "Generate symbols of generated dart functions for debugging with GDB");
 DECLARE_FLAG(bool, trace_compiler);
 DECLARE_FLAG(bool, enable_type_checks);
 
@@ skipping 5520 matching lines @@
   }
 #endif  // DEBUG
 }
 
 
 void Stackmap::SetCode(const Code& code) const {
   StorePointer(&raw_ptr()->code_, code.raw());
 }
 
 
-// Return the bit offset of the highest bit set.
-intptr_t Stackmap::Maximum() const {
-  intptr_t bound = SizeInBits();
-  for (intptr_t i = (bound - 1); i >= 0; i--) {
-    if (IsObject(i)) return i;
-  }
-  return kNoMaximum;
-}
-
-
-// Return the bit offset of the lowest bit set.
-intptr_t Stackmap::Minimum() const {
-  intptr_t bound = SizeInBits();
-  for (intptr_t i = 0; i < bound; i++) {
-    if (IsObject(i)) return i;
-  }
-  return kNoMinimum;
-}
-
-
 bool Stackmap::GetBit(intptr_t bit_offset) const {
   ASSERT(InRange(bit_offset));
   int byte_offset = bit_offset >> kBitsPerByteLog2;
   int bit_remainder = bit_offset & (kBitsPerByte - 1);
   uint8_t byte_mask = 1U << bit_remainder;
   uint8_t byte = raw_ptr()->data_[byte_offset];
   return (byte & byte_mask);
 }
 
 
 void Stackmap::SetBit(intptr_t bit_offset, bool value) const {
   ASSERT(InRange(bit_offset));
   int byte_offset = bit_offset >> kBitsPerByteLog2;
   int bit_remainder = bit_offset & (kBitsPerByte - 1);
   uint8_t byte_mask = 1U << bit_remainder;
   uint8_t* byte_addr = &(raw_ptr()->data_[byte_offset]);
   if (value) {
     *byte_addr |= byte_mask;
   } else {
     *byte_addr &= ~byte_mask;
   }
 }
 
 
-RawStackmap* Stackmap::New(uword pc, const Code& code, BitmapBuilder* bmap) {
+RawStackmap* Stackmap::New(uword pc_offset, BitmapBuilder* bmap) {
   const Class& cls = Class::Handle(Object::stackmap_class());
   ASSERT(!cls.IsNull());
   ASSERT(bmap != NULL);
   Stackmap& result = Stackmap::Handle();
   intptr_t size = bmap->SizeInBytes();
   {
     // Stackmap data objects are associated with a code object, allocate them
     // in old generation.
     RawObject* raw =
         Object::Allocate(cls, Stackmap::InstanceSize(size), Heap::kOld);
     NoGCScope no_gc;
     result ^= raw;
     result.set_bitmap_size_in_bytes(size);
   }
-  result.set_pc(pc);
-  result.set_code(code);
+  result.SetPC(pc_offset);
   intptr_t bound = bmap->SizeInBits();
   for (intptr_t i = 0; i < bound; i++) {
     result.SetBit(i, bmap->Get(i));
   }
+  result.SetMinBitOffset(bmap->Minimum());
+  result.SetMaxBitOffset(bmap->Maximum());
   return result.raw();
 }
 
 
 void Stackmap::set_bitmap_size_in_bytes(intptr_t value) const {
   // This is only safe because we create a new Smi, which does not cause
   // heap allocation.
   raw_ptr()->bitmap_size_in_bytes_ = Smi::New(value);
 }
 
 
-void Stackmap::set_pc(uword value) const {
-  raw_ptr()->pc_ = value;
-}
-
-
-void Stackmap::set_code(const Code& code) const {
-  StorePointer(&raw_ptr()->code_, code.raw());
-}
-
-
 const char* Stackmap::ToCString() const {
   if (IsNull()) {
     return "{null}";
   } else {
     intptr_t index = OS::SNPrint(NULL, 0, "0x%lx { ", PC());
-    intptr_t alloc_size = index + ((Maximum() + 1) * 2) + 2;  // "{ 1 0 .... }".
+    intptr_t alloc_size =
+        index + ((MaximumBitOffset() + 1) * 2) + 2;  // "{ 1 0 .... }".
     Isolate* isolate = Isolate::Current();
     char* chars = reinterpret_cast<char*>(
         isolate->current_zone()->Allocate(alloc_size));
     index = OS::SNPrint(chars, alloc_size, "0x%lx { ", PC());
-    for (intptr_t i = 0; i <= Maximum(); i++) {
+    for (intptr_t i = 0; i <= MaximumBitOffset(); i++) {
       index += OS::SNPrint((chars + index),
                            (alloc_size - index),
                            "%d ",
                            IsObject(i) ? 1 : 0);
     }
     OS::SNPrint((chars + index), (alloc_size - index), "}");
     return chars;
   }
 }
 
@@ skipping 312 matching lines @@
   for (intptr_t i = 0; i < descriptors.Length(); i++) {
     if (descriptors.DescriptorKind(i) == PcDescriptors::kIcCall) {
       node_ids->Add(descriptors.NodeId(i));
       ic_data_obj = CodePatcher::GetInstanceCallIcDataAt(descriptors.PC(i));
       ic_data_objs.Add(ic_data_obj);
     }
   }
 }
 
 
+RawStackmap* Code::GetStackmap(uword pc, Array* maps, Stackmap* map) const {
+  // This code is used only during iterating frames during a GC and hence
+  // it should not in turn start a GC.
+  NoGCScope no_gc;
+  if (stackmaps() == Array::null()) {
+    // No stack maps are present in the code object which means this
+    // frame relies on tagged pointers.
+    return Stackmap::null();
+  }
+  // A stack map is present in the code object, use the stack map to visit
+  // frame slots which are marked as having objects.
+  RawStackmap* previous_map = Stackmap::null();
+  *maps = stackmaps();
+  *map = Stackmap::null();
+  for (intptr_t i = 0; i < maps->Length(); i++) {
+    *map ^= maps->At(i);
+    ASSERT(!map->IsNull());
+    if (map->PC() == pc) {
+      break;  // We found a stack map for this frame.
+    }
+    if (map->PC() > pc) {
+      // We have not found a stackmap corresponding to the PC of this frame,
+      // we will use the closest previous stack map.
+      *map = previous_map;
+      break;
+    }
+    previous_map = map->raw();
+  }
+  return map->raw();
+}
+
+
 RawContext* Context::New(intptr_t num_variables, Heap::Space space) {
   ASSERT(num_variables >= 0);
 
   const Class& context_class = Class::Handle(Object::context_class());
   Context& result = Context::Handle();
   {
     RawObject* raw = Object::Allocate(context_class,
                                       Context::InstanceSize(num_variables),
                                       space);
     NoGCScope no_gc;
@@ skipping 2864 matching lines @@
 }
 
 
 void Stacktrace::set_pc_offset_array(const Array& pc_offset_array) const {
   StorePointer(&raw_ptr()->pc_offset_array_, pc_offset_array.raw());
 }
 
 
 void Stacktrace::SetupStacktrace(intptr_t index,
                                  const GrowableArray<uword>& frame_pcs) const {
-  ASSERT(Isolate::Current() != NULL);
-  CodeIndexTable* code_index_table = Isolate::Current()->code_index_table();
-  ASSERT(code_index_table != NULL);
-  Function& function = Function::Handle();
-  Code& code = Code::Handle();
-  Smi& pc_offset = Smi::Handle();
+  Isolate* isolate = Isolate::Current();
+  ASSERT(isolate != NULL);
+  Function& function = Function::Handle(isolate, Function::null());
+  Code& code = Code::Handle(isolate, Code::null());
+  Smi& pc_offset = Smi::Handle(isolate, Smi::New(0));
   const Array& function_array = Array::Handle(raw_ptr()->function_array_);
   const Array& code_array = Array::Handle(raw_ptr()->code_array_);
   const Array& pc_offset_array = Array::Handle(raw_ptr()->pc_offset_array_);
   for (intptr_t i = 0; i < frame_pcs.length(); i++) {
-    code = code_index_table->LookupCode(frame_pcs[i]);
+    code = StackFrame::LookupCode(isolate, frame_pcs[i]);
     ASSERT(!code.IsNull());
     function = code.function();
     function_array.SetAt((index + i), function);
     code_array.SetAt((index + i), code);
     pc_offset = Smi::New(frame_pcs[i] - code.EntryPoint());
     pc_offset_array.SetAt((index + i), pc_offset);
   }
 }
 
 
@@ skipping 204 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart