Issue 10005010: Implement object allocation/construction as effect (no result), sequence labels and unchaining fro…

Issue 10005010: Implement object allocation/construction as effect (no result), sequence labels and unchaining fro… (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement object allocation/construction as effect (no result), sequence labels and unchaining from context. Committed: https://code.google.com/p/dart/source/detail?r=6226

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -47 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1 2	1 chunk	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View	1 2	1 chunk	+2 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	6 chunks	+62 lines, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10005010/diff/4001/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): https://chromiumcodereview.appspot.com/10005010/diff/4001/runtime/vm/code_generator_ia32.cc#newcode968 runtime/vm/code_generator_ia32.cc:968: UNREACHABLE(); Good point. A break out of the ...

8 years, 8 months ago (2012-04-05 16:03:57 UTC) #2

srdjan

8 years, 8 months ago (2012-04-05 16:23:11 UTC) #3

https://chromiumcodereview.appspot.com/10005010/diff/4001/runtime/vm/code_gen...
File runtime/vm/code_generator_ia32.cc (right):

https://chromiumcodereview.appspot.com/10005010/diff/4001/runtime/vm/code_gen...
runtime/vm/code_generator_ia32.cc:968: UNREACHABLE();
On 2012/04/05 16:03:57, regis wrote:
> Good point. A break out of the outermost sequence can only be a return
> statement.
> An assert instead of a condition + unreachable would not generate any code in
> release mode, although efficiency is not an issue here.

Done.

https://chromiumcodereview.appspot.com/10005010/diff/4001/runtime/vm/code_gen...
File runtime/vm/code_generator_x64.cc (right):

https://chromiumcodereview.appspot.com/10005010/diff/4001/runtime/vm/code_gen...
runtime/vm/code_generator_x64.cc:910: UNREACHABLE();
On 2012/04/05 16:03:57, regis wrote:
> Ditto (if you replaced by assert in 32-bit version).

Done.

Expand Messages | Collapse Messages