Issue 10001008: Many type fixes.

Issue 10001008: Many type fixes. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Many type fixes. Committed: https://code.google.com/p/dart/source/detail?r=6576

Patch Set 2 : Address comments. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -67 lines)			Patch
M	lib/compiler/implementation/compile_time_constants.dart	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/scanner/byte_strings.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/scanner/keyword.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/scanner/listener.dart	View	1	6 chunks	+17 lines, -15 lines	0 comments	Download
M	lib/compiler/implementation/scanner/node_scanner_bench.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/scanner_task.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/scanner/vm_scanner_bench.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/bailout.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View		4 chunks	+13 lines, -13 lines	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/tree/nodes.dart	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/tree/unparser.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/util/link_implementation.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Thanks, Florian! https://chromiumcodereview.appspot.com/10001008/diff/1/lib/compiler/implementation/scanner/byte_strings.dart File lib/compiler/implementation/scanner/byte_strings.dart (right): https://chromiumcodereview.appspot.com/10001008/diff/1/lib/compiler/implementation/scanner/byte_strings.dart#newcode52 lib/compiler/implementation/scanner/byte_strings.dart:52: String get stringValue() => null; This ...

8 years, 8 months ago (2012-04-16 13:10:46 UTC) #2

floitsch

I'm committing this now, but still added Peter so that he sees the comments. https://chromiumcodereview.appspot.com/10001008/diff/1/lib/compiler/implementation/scanner/byte_strings.dart ...

8 years, 8 months ago (2012-04-16 13:57:57 UTC) #3

ahe

8 years, 8 months ago (2012-04-16 15:02:28 UTC) #4

Thank you for doing this, Florian!

Cheers,
Peter

https://chromiumcodereview.appspot.com/10001008/diff/1/lib/compiler/implement...
File lib/compiler/implementation/scanner/byte_strings.dart (right):

https://chromiumcodereview.appspot.com/10001008/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/byte_strings.dart:52: String get
stringValue() => null;
On 2012/04/16 13:57:57, floitsch wrote:
> On 2012/04/16 13:10:46, kasperl wrote:
> > This seems broken. Why is the string value null?
> 
> Peter asked me to return null.

Which is the correct thing to do. This method only returns something for tokens
that have a "static" string value (operators and keywords).

https://chromiumcodereview.appspot.com/10001008/diff/1/lib/compiler/implement...
File lib/compiler/implementation/scanner/node_scanner_bench.dart (right):

https://chromiumcodereview.appspot.com/10001008/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/node_scanner_bench.dart:1: // Copyright (c)
2012, the Dart project authors.  Please see the AUTHORS file
On 2012/04/16 13:57:57, floitsch wrote:
> On 2012/04/16 13:10:46, kasperl wrote:
> > Can we get rid of this file? Maybe ask Peter.
> 
> Peter changed this file with me. So I expect that he wants to revive it
> eventually.

I'm not sure this works anymore. I think I should remove it.

Expand Messages | Collapse Messages