Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: lib/compiler/implementation/compile_time_constants.dart

Issue 10001008: Many type fixes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compile_time_constants.dart
diff --git a/lib/compiler/implementation/compile_time_constants.dart b/lib/compiler/implementation/compile_time_constants.dart
index d660d9e1694c2c339138bdead8ae01a1561743a9..1f4b57fb4b4712149c90d05a3d7a8f9c74c7f7e2 100644
--- a/lib/compiler/implementation/compile_time_constants.dart
+++ b/lib/compiler/implementation/compile_time_constants.dart
@@ -795,10 +795,11 @@ class CompileTimeConstantEvaluator extends AbstractVisitor {
Constant expression = evaluate(part.expression);
DartString expressionString;
if (expression.isNum() || expression.isBool()) {
- Object value = expression.value;
- expressionString = new DartString.literal(value.toString());
+ PrimitiveConstant primitive = expression;
+ expressionString = new DartString.literal(primitive.value.toString());
} else if (expression.isString()) {
- expressionString = expression.value;
+ PrimitiveConstant primitive = expression;
+ expressionString = primitive.value;
} else {
error(part.expression);
}
« no previous file with comments | « no previous file | lib/compiler/implementation/compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698