Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 10850007: Temporarily allow warnings in libvpx (Closed)

Created:
8 years, 4 months ago by scottmg
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Temporarily allow warnings in libvpx It's been difficult to pin down a build of libvpx that doesn't cause warnings on Windows. Override the warnings-as-errors flag for libvpx so that it can be turned on for everything else, to prevent regressions in other projects while trying to fix the remaining libvpx warnings. Goes with http://chromiumcodereview.appspot.com/10810019/ R=thakis@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M libvpx.gyp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
8 years, 4 months ago (2012-08-01 22:30:58 UTC) #1
Nico
LGTM, but LBTM with tracking bug referenced from the comment On Wed, Aug 1, 2012 ...
8 years, 4 months ago (2012-08-01 22:40:21 UTC) #2
scottmg
On Wed, Aug 1, 2012 at 3:40 PM, Nico Weber <thakis@chromium.org> wrote: > LGTM, but ...
8 years, 4 months ago (2012-08-01 22:43:44 UTC) #3
Nico
https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp File libvpx.gyp (right): https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp#newcode88 libvpx.gyp:88: 'WarnAsError': 'false', # TODO(scottmg): Enable it. I mean "# ...
8 years, 4 months ago (2012-08-01 22:47:34 UTC) #4
scottmg
On 2012/08/01 22:47:34, Nico wrote: > https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp > File libvpx.gyp (right): > > https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp#newcode88 > ...
8 years, 4 months ago (2012-08-01 22:52:37 UTC) #5
scottmg
8 years, 4 months ago (2012-08-01 23:02:43 UTC) #6
On 2012/08/01 22:52:37, scottmg wrote:
> On 2012/08/01 22:47:34, Nico wrote:
> > https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp
> > File libvpx.gyp (right):
> > 
> > https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp#newcode88
> > libvpx.gyp:88: 'WarnAsError': 'false', # TODO(scottmg): Enable it.
> > I mean "# TODO(scottmg): Enable this for libvpx, http://crbug.com/YYY%2522,
> where
> > YYY is the # of a to-be-filed tracking bug for enabling warnings-as-errors
for
> > libvpx
> 
> Sorry, gotcha. Done.

Sigh, doesn't work anyway because doesn't gyp doesn't handle the msvs_settings
dict merge properly.

Powered by Google App Engine
This is Rietveld 408576698