Temporarily allow warnings in libvpx

Temporarily allow warnings in libvpx

It's been difficult to pin down a build of libvpx that doesn't cause warnings
on Windows. Override the warnings-as-errors flag for libvpx so that it can be
turned on for everything else, to prevent regressions in other projects while
trying to fix the remaining libvpx warnings. Goes with
http://chromiumcodereview.appspot.com/10810019/

R=thakis@chromium.org

[Nico, 2012-08-01 22:40:21]

LGTM, but LBTM with tracking bug referenced from the comment

On Wed, Aug 1, 2012 at 3:30 PM,  <scottmg@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Temporarily allow warnings in libvpx
>
> It's been difficult to pin down a build of libvpx that doesn't cause
> warnings
> on Windows. Override the warnings-as-errors flag for libvpx so that it can
> be
> turned on for everything else, to prevent regressions in other projects
> while
> trying to fix the remaining libvpx warnings. Goes with
> http://chromiumcodereview.appspot.com/10810019/  This patch doesn't change
> any
> behaviour until that one lands.
>
> R=thakis@chromium.org
>
> Please review this at https://chromiumcodereview.appspot.com/10850007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/libvpx/
>
> Affected files:
>   M     libvpx.gyp
>
>
> Index: libvpx.gyp
> ===================================================================
> --- libvpx.gyp  (revision 149334)
> +++ libvpx.gyp  (working copy)
> @@ -83,6 +83,11 @@
>            # from asm files. This flag disables UseLibraryDependencyInputs
> to
>            # avoid this problem.
>            'msvs_2010_disable_uldi_when_referenced': 1,
> +          'msvs_settings': {
> +            'VCCLCompilerTool': {
> +              'WarnAsError': 'false', # TODO(scottmg): Enable it.
> +            },
> +          },
>            'conditions': [
>              [ 'target_arch=="ia32"', {
>                'includes': [
>
>

[scottmg, 2012-08-01 22:43:44]

On Wed, Aug 1, 2012 at 3:40 PM, Nico Weber <thakis@chromium.org> wrote:

> LGTM, but LBTM with tracking bug referenced from the comment
>
>
Sorry, what? You mean you don't like
http://chromiumcodereview.appspot.com/10810019/ ?


> On Wed, Aug 1, 2012 at 3:30 PM,  <scottmg@chromium.org> wrote:
> > Reviewers: Nico,
> >
> > Description:
> > Temporarily allow warnings in libvpx
> >
> > It's been difficult to pin down a build of libvpx that doesn't cause
> > warnings
> > on Windows. Override the warnings-as-errors flag for libvpx so that it
> can
> > be
> > turned on for everything else, to prevent regressions in other projects
> > while
> > trying to fix the remaining libvpx warnings. Goes with
> > http://chromiumcodereview.appspot.com/10810019/  This patch doesn't
> change
> > any
> > behaviour until that one lands.
> >
> > R=thakis@chromium.org
> >
> > Please review this at https://chromiumcodereview.appspot.com/10850007/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/libvpx/
> >
> > Affected files:
> >   M     libvpx.gyp
> >
> >
> > Index: libvpx.gyp
> > ===================================================================
> > --- libvpx.gyp  (revision 149334)
> > +++ libvpx.gyp  (working copy)
> > @@ -83,6 +83,11 @@
> >            # from asm files. This flag disables
> UseLibraryDependencyInputs
> > to
> >            # avoid this problem.
> >            'msvs_2010_disable_uldi_when_referenced': 1,
> > +          'msvs_settings': {
> > +            'VCCLCompilerTool': {
> > +              'WarnAsError': 'false', # TODO(scottmg): Enable it.
> > +            },
> > +          },
> >            'conditions': [
> >              [ 'target_arch=="ia32"', {
> >                'includes': [
> >
> >
>

[Nico, 2012-08-01 22:47:34]

https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp
File libvpx.gyp (right):

https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp#newcode88
libvpx.gyp:88: 'WarnAsError': 'false', # TODO(scottmg): Enable it.
I mean "# TODO(scottmg): Enable this for libvpx, http://crbug.com/YYY", where
YYY is the # of a to-be-filed tracking bug for enabling warnings-as-errors for
libvpx

[scottmg, 2012-08-01 22:52:37]

On 2012/08/01 22:47:34, Nico wrote:
> https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp
> File libvpx.gyp (right):
> 
> https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp#newcode88
> libvpx.gyp:88: 'WarnAsError': 'false', # TODO(scottmg): Enable it.
> I mean "# TODO(scottmg): Enable this for libvpx, http://crbug.com/YYY%22,
where
> YYY is the # of a to-be-filed tracking bug for enabling warnings-as-errors for
> libvpx

Sorry, gotcha. Done.

[scottmg, 2012-08-01 23:02:43]

On 2012/08/01 22:52:37, scottmg wrote:
> On 2012/08/01 22:47:34, Nico wrote:
> > https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp
> > File libvpx.gyp (right):
> > 
> > https://chromiumcodereview.appspot.com/10850007/diff/1/libvpx.gyp#newcode88
> > libvpx.gyp:88: 'WarnAsError': 'false', # TODO(scottmg): Enable it.
> > I mean "# TODO(scottmg): Enable this for libvpx, http://crbug.com/YYY%2522,
> where
> > YYY is the # of a to-be-filed tracking bug for enabling warnings-as-errors
for
> > libvpx
> 
> Sorry, gotcha. Done.

Sigh, doesn't work anyway because doesn't gyp doesn't handle the msvs_settings
dict merge properly.