Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: chrome/browser/performance_monitor/constants.h

Issue 10815079: CPM: revised unclean exit watching, revised renderer crash test (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/constants.h
diff --git a/chrome/browser/performance_monitor/constants.h b/chrome/browser/performance_monitor/constants.h
index a3455b0a4e83dbf08ed3049f5d1706da0110e88f..0c51011e62d4ac4fbfb7d67f4fe6654aa4653b5e 100644
--- a/chrome/browser/performance_monitor/constants.h
+++ b/chrome/browser/performance_monitor/constants.h
@@ -7,26 +7,27 @@
namespace performance_monitor {
-// TODO(chebert): i18n on all constants.
-extern const char kMetricNotFoundError[];
+// Constants which are used by the PerformanceMonitor and its related classes.
+// The constants should be documented alongside the definition of their values
+// in the .cc file.
-// Any metric that is not associated with a specific activity will use this as
-// its activity.
+extern const char kMetricNotFoundError[];
extern const char kProcessChromeAggregate[];
-// Metrics keys for statistics gathering.
+// State tokens
+extern const char kStateChromeVersion[];
+extern const char kStateProfilePrefix[];
+
+// Metric details
extern const char kMetricCPUUsageName[];
extern const char kMetricCPUUsageDescription[];
extern const char kMetricCPUUsageUnits[];
extern const double kMetricCPUUsageTickSize;
-
extern const char kMetricPrivateMemoryUsageName[];
extern const char kMetricPrivateMemoryUsageDescription[];
extern const char kMetricPrivateMemoryUsageUnits[];
extern const double kMetricPrivateMemoryUsageTickSize;
-extern const char kStateChromeVersion[];
-
} // namespace performance_monitor
#endif // CHROME_BROWSER_PERFORMANCE_MONITOR_CONSTANTS_H_

Powered by Google App Engine
This is Rietveld 408576698