Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3012)

Unified Diff: chrome/browser/performance_monitor/constants.cc

Issue 10815079: CPM: revised unclean exit watching, revised renderer crash test (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/constants.cc
diff --git a/chrome/browser/performance_monitor/constants.cc b/chrome/browser/performance_monitor/constants.cc
index 298b9bc467c7aac6b7cbc5d3e07eaf8e1a985526..53d494fadea2ce2f8814f25fd71f91ee53e0351d 100644
--- a/chrome/browser/performance_monitor/constants.cc
+++ b/chrome/browser/performance_monitor/constants.cc
@@ -6,22 +6,41 @@
namespace performance_monitor {
-// The key to insert/retrieve information about the chrome version from the
-// database.
-const char kStateChromeVersion[] = "chrome_version";
-const char kMetricNotFoundError[] = "Mertic details not found.";
+// TODO(chebert): i18n on all constants.
+
+// The error message displayed when a metric's details are not found.
+const char kMetricNotFoundError[] = "Metric details not found.";
+
+// Any metric that is not associated with a specific activity will use this as
+// its activity.
const char kProcessChromeAggregate[] = "chrome_aggregate";
+// Tokens to retrieve state values from the database.
+
+// Stores information about the previous chrome version.
+const char kStateChromeVersion[] = "chrome_version";
+// The prefix to the state of a profile's name, to prevent any possible naming
+// collisions in the database.
+const char kStateProfilePrefix[] = "profile";
+
+// Metric details follow.
+// All metric details have the following constants:
+// - Name
+// - Description
+// - Units
+// - TickSize (the smallest possible maximum which will be viewed in the ui.)
+
+// CPU Usage
const char kMetricCPUUsageName[] = "CPU Usage";
const char kMetricCPUUsageDescription[] = "The CPU usage measured in percent.";
const char kMetricCPUUsageUnits[] = "percent";
const double kMetricCPUUsageTickSize = 100.0;
+// Private Memory Usage
const char kMetricPrivateMemoryUsageName[] = "Private Memory Usage";
const char kMetricPrivateMemoryUsageDescription[] =
"The private memory usage measured in bytes.";
const char kMetricPrivateMemoryUsageUnits[] = "percent";
const double kMetricPrivateMemoryUsageTickSize = 10000000.0;
-
} // namespace performance_monitor

Powered by Google App Engine
This is Rietveld 408576698