Issue 10810019: Turn on warnings-as-errors on Windows third party code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10810019: Turn on warnings-as-errors on Windows third party code (Closed)

Created:
8 years, 5 months ago by scottmg

Modified:
8 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Turn on warnings-as-errors on Windows third party code - qcms warnings are fixed in HEAD via substantial reorganization, but since they're minor (signedness for small ints) just disable - yasm has had patch posted and bug issue (for a couple months) but maintainer doesn't seem motivated to merge, so just disable (they're also minor/harmless) - turn on WarnAsError on Windows Debug for non-chromium code to prevent regressions BUG= TEST=

Patch Set 1 #

Patch Set 2 : new tree #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
M	build/common.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/qcms/qcms.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/yasm/yasm.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download