build/common.gypi - Issue 10810019: Turn on warnings-as-errors on Windows third party code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 10810019: Turn on warnings-as-errors on Windows third party code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new tree Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 1b73dcd310bea7fbf3d54405554f158c319ed162..5479aa4e3b18ed4df3ac3a4a00996aa7dbd4449b 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1645,7 +1645,7 @@

'msvs_settings': {

'VCCLCompilerTool': {

'WarningLevel': '3',

- 'WarnAsError': 'false', # TODO(maruel): Enable it.

+ 'WarnAsError': 'true',

'Detect64BitPortabilityProblems': 'false',

« no previous file with comments | « no previous file | third_party/qcms/qcms.gyp » ('j') | no next file with comments »