content/public/common/file_chooser_params.h - Issue 10536066: android content shell bringup.

Unified Diff: content/public/common/file_chooser_params.h

Issue 10536066: android content shell bringup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add comments Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« content/public/browser/content_view.cc ('K') | « content/public/browser/content_view.cc ('k') | content/public/common/find_match_rect_android.h » ('j') | content/public/common/find_match_rect_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/file_chooser_params.h

diff --git a/content/public/common/file_chooser_params.h b/content/public/common/file_chooser_params.h

index acc7fade90eab74c468a73259f68af17f0823316..29762e1395aea4fdbe5cf051a8a42c59912c214e 100644

--- a/content/public/common/file_chooser_params.h

+++ b/content/public/common/file_chooser_params.h

@@ -46,6 +46,13 @@ struct CONTENT_EXPORT FileChooserParams {

// A list of valid lower-cased MIME types or file extensions specified in an

// input element. It is used to restrict selectable files to such types.

std::vector<string16> accept_types;

+#if defined(OS_ANDROID)

+ // Paramaterization of choice on the Java size (e.g. from

+ // filesystem). See SelectFileDialog.java.

jam 2012/06/08 23:45:09 nit: this can fit on the previous line I'm also c

John Grabowski 2012/06/12 01:46:30 Sorry. If "camera", will perform a capture from t

jam 2012/06/12 17:44:02 so did you mean to update this?

John Grabowski 2012/06/13 22:12:29 Like I said, it is unclear how much I want to doc

jam 2012/06/14 01:31:40 It's just that this comment doesn't mean anything

John Grabowski 2012/06/14 04:20:49 Yes, size not side. I will email you the java fil

jam 2012/06/14 16:08:57 My suggestion is really just to make this legible

My suggestion is really just to make this legible to someone reading this file who's not familiar with the java side, since this struct is used on all platforms. I agree no need to duplicate the java comment in its entirety. Something like this would make it easier to understand: // Used to select items other than files, i.e. camera/mic. See SelectFileDialog.java for more details.

John Grabowski 2012/06/14 17:56:30 Done

On 2012/06/14 16:08:57, John Abd-El-Malek wrote: > On 2012/06/14 04:20:49, John Grabowski wrote: > > On 2012/06/14 01:31:40, John Abd-El-Malek wrote: > > > On 2012/06/13 22:12:29, John Grabowski wrote: > > > > On 2012/06/12 17:44:02, John Abd-El-Malek wrote: > > > > > On 2012/06/12 01:46:30, John Grabowski wrote: > > > > > > On 2012/06/08 23:45:09, John Abd-El-Malek wrote: > > > > > > > nit: this can fit on the previous line > > > > > > > > > > > > > > I'm also confused about what this parameter means. it's named > > "capture" > > > > but > > > > > > you > > > > > > > say "Paramaterization of choice" which I can't tell what that is. > > > > > > > > > > > > Sorry. If "camera", will perform a capture from the camera (e.g. for > > > select > > > > > > image, this can be the "file location"). It is unclear how much I > want > > to > > > > doc > > > > > > the java in here but am open to suggestions for clarity. > > > > > > > > > > so did you mean to update this? > > > > > > > > Like I said, it is unclear how much I want to doc the java interface in > > native > > > > code. I will add what you think is relevant (which appears to be more > than > > I > > > > have added already)? > > > > > > It's just that this comment doesn't mean anything to me. Is this because I'm > > not > > > familiar with the android port? > > > > > > 51 // Paramaterization of choice on the Java size (e.g. from > > > 52 // filesystem). See SelectFileDialog.java. > > > > > > small thing first: do you mean side instead of size? > > > > > > but also, what does "Paramaterization of choice" mean?? > > > > > > and I still don't understand camera vs capture? > > > > Yes, size not side. I will email you the java file (not upstreamed yet). > > My suggestion is really just to make this legible to someone reading this file > who's not familiar with the java side, since this struct is used on all > platforms. I agree no need to duplicate the java comment in its entirety. > Something like this would make it easier to understand: > > // Used to select items other than files, i.e. camera/mic. See > SelectFileDialog.java for more details.

Done

+ // TODO(jrg): upstream SelectFileDialog.java! Currently lives in chrome/.

+ string16 capture;

+#endif

};

} // namespace content