android content shell bringup.

content/public/common/file_chooser_params.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_FILE_CHOOSER_PARAMS_H_
 #define CONTENT_PUBLIC_COMMON_FILE_CHOOSER_PARAMS_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 28 matching lines @@
   // Title to be used for the dialog. This may be empty for the default title,
   // which will be either "Open" or "Save" depending on the mode.
   string16 title;
 
   // Default file name to select in the dialog.
   FilePath default_file_name;
 
   // A list of valid lower-cased MIME types or file extensions specified in an
   // input element. It is used to restrict selectable files to such types.
   std::vector<string16> accept_types;
+
+#if defined(OS_ANDROID)
+  // Paramaterization of choice on the Java size (e.g. from
+  // filesystem).  See SelectFileDialog.java.

[jam, 2012/06/08 23:45:09]

nit: this can fit on the previous line

I'm also confused about what this parameter means. it's named "capture" but you
say "Paramaterization of choice" which I can't tell what that is.

[John Grabowski, 2012/06/12 01:46:30]

Sorry.  If "camera", will perform a capture from the camera (e.g. for select
image, this can be the "file location").  It is unclear how much I want to doc
the java in here but am open to suggestions for clarity.

[jam, 2012/06/12 17:44:02]

so did you mean to update this?

[John Grabowski, 2012/06/13 22:12:29]

Like I said, it is unclear how much I want to doc the java interface in native
code.  I will add what you think is relevant (which appears to be more than I
have added already)?

[jam, 2012/06/14 01:31:40]

It's just that this comment doesn't mean anything to me. Is this because I'm not
familiar with the android port?

 51   // Paramaterization of choice on the Java size (e.g. from
 52   // filesystem).  See SelectFileDialog.java.

small thing first: do you mean side instead of size?

but also, what does "Paramaterization of choice" mean??

and I still don't understand camera vs capture?

[John Grabowski, 2012/06/14 04:20:49]

Yes, size not side.  I will email you the java file (not upstreamed yet).

[jam, 2012/06/14 16:08:57]

My suggestion is really just to make this legible to someone reading this file
who's not familiar with the java side, since this struct is used on all
platforms. I agree no need to duplicate the java comment in its entirety.
Something like this would make it easier to understand:

// Used to select items other than files, i.e. camera/mic. See
SelectFileDialog.java for more details.

[John Grabowski, 2012/06/14 17:56:30]

Done

+  // TODO(jrg): upstream SelectFileDialog.java!  Currently lives in chrome/.
+  string16 capture;
+#endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_FILE_CHOOSER_PARAMS_H_