Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: ffmpeg.gyp

Issue 10387100: Removed assumption that any ARM build is ARMv7, fallback to ARMv6 to fix Raspberry Pi build Base URL: http://git.chromium.org/chromium/third_party/ffmpeg.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ffmpeg.gyp
diff --git a/ffmpeg.gyp b/ffmpeg.gyp
index 41e10a437efd8a371107b7cec457efc2a3462100..1c6c157cfa51e98d75cb165bb1cd0b7163117eed 100644
--- a/ffmpeg.gyp
+++ b/ffmpeg.gyp
@@ -166,7 +166,7 @@
'-fno-omit-frame-pointer',
],
}], # target_arch == "ia32"
- ['target_arch == "arm"', {
+ ['target_arch == "arm" and armv7 == 1', {
# TODO(ihf): See the long comment in build_ffmpeg.sh
# We want to be consistent with CrOS and have configured
# ffmpeg for thumb. Protect yourself from -marm.
@@ -192,6 +192,18 @@
}],
],
}],
+ ['target_arch == "arm" and armv7 == 0', {
Ami GONE FROM CHROMIUM 2012/05/12 15:10:14 Would this be better placed in src/build/common.gy
+ 'cflags!': [
+ '-mthumb',
Ami GONE FROM CHROMIUM 2012/05/14 18:22:53 Actually I'm surprised this CL works at all, consi
+ ],
+ 'cflags': [
+ '-marm',
+ '-march=armv6j',
+ '-mtune=arm1176jzf-s',
+ '-mfloat-abi=softfp',
+ '-mfpu=vfp',
+ ],
+ }],
['os_posix == 1 and OS != "mac"', {
'defines': [
'_ISOC99_SOURCE',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698