Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: ffmpeg.gyp

Issue 10387100: Removed assumption that any ARM build is ARMv7, fallback to ARMv6 to fix Raspberry Pi build Base URL: http://git.chromium.org/chromium/third_party/ffmpeg.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # There's a couple key GYP variables that control how FFmpeg is built: 5 # There's a couple key GYP variables that control how FFmpeg is built:
6 # ffmpeg_branding 6 # ffmpeg_branding
7 # Controls whether we build the Chromium or Google Chrome version of 7 # Controls whether we build the Chromium or Google Chrome version of
8 # FFmpeg. The Google Chrome version contains additional codecs. 8 # FFmpeg. The Google Chrome version contains additional codecs.
9 # Typical values are Chromium, Chrome, ChromiumOS, and ChromeOS. 9 # Typical values are Chromium, Chrome, ChromiumOS, and ChromeOS.
10 # use_system_ffmpeg 10 # use_system_ffmpeg
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 'cflags!': [ 159 'cflags!': [
160 '-fno-omit-frame-pointer', 160 '-fno-omit-frame-pointer',
161 ], 161 ],
162 'debug_extra_cflags!': [ 162 'debug_extra_cflags!': [
163 '-fno-omit-frame-pointer', 163 '-fno-omit-frame-pointer',
164 ], 164 ],
165 'release_extra_cflags!': [ 165 'release_extra_cflags!': [
166 '-fno-omit-frame-pointer', 166 '-fno-omit-frame-pointer',
167 ], 167 ],
168 }], # target_arch == "ia32" 168 }], # target_arch == "ia32"
169 ['target_arch == "arm"', { 169 ['target_arch == "arm" and armv7 == 1', {
170 # TODO(ihf): See the long comment in build_ffmpeg.sh 170 # TODO(ihf): See the long comment in build_ffmpeg.sh
171 # We want to be consistent with CrOS and have configured 171 # We want to be consistent with CrOS and have configured
172 # ffmpeg for thumb. Protect yourself from -marm. 172 # ffmpeg for thumb. Protect yourself from -marm.
173 'cflags!': [ 173 'cflags!': [
174 '-marm', 174 '-marm',
175 ], 175 ],
176 'cflags': [ 176 'cflags': [
177 '-mthumb', 177 '-mthumb',
178 '-march=armv7-a', 178 '-march=armv7-a',
179 '-mtune=cortex-a8', 179 '-mtune=cortex-a8',
180 '-mfloat-abi=softfp', 180 '-mfloat-abi=softfp',
181 ], 181 ],
182 'conditions': [ 182 'conditions': [
183 ['arm_neon == 0', { 183 ['arm_neon == 0', {
184 'cflags': [ 184 'cflags': [
185 '-mfpu=vfpv3-d16', 185 '-mfpu=vfpv3-d16',
186 ], 186 ],
187 }], 187 }],
188 ['arm_neon == 1', { 188 ['arm_neon == 1', {
189 'cflags': [ 189 'cflags': [
190 '-mfpu=neon', 190 '-mfpu=neon',
191 ], 191 ],
192 }], 192 }],
193 ], 193 ],
194 }], 194 }],
195 ['target_arch == "arm" and armv7 == 0', {
Ami GONE FROM CHROMIUM 2012/05/12 15:10:14 Would this be better placed in src/build/common.gy
196 'cflags!': [
197 '-mthumb',
Ami GONE FROM CHROMIUM 2012/05/14 18:22:53 Actually I'm surprised this CL works at all, consi
198 ],
199 'cflags': [
200 '-marm',
201 '-march=armv6j',
202 '-mtune=arm1176jzf-s',
203 '-mfloat-abi=softfp',
204 '-mfpu=vfp',
205 ],
206 }],
195 ['os_posix == 1 and OS != "mac"', { 207 ['os_posix == 1 and OS != "mac"', {
196 'defines': [ 208 'defines': [
197 '_ISOC99_SOURCE', 209 '_ISOC99_SOURCE',
198 '_LARGEFILE_SOURCE', 210 '_LARGEFILE_SOURCE',
199 # BUG(ihf): ffmpeg compiles with this define. But according to 211 # BUG(ihf): ffmpeg compiles with this define. But according to
200 # ajwong: I wouldn't change _FILE_OFFSET_BITS. That's a scary c hange 212 # ajwong: I wouldn't change _FILE_OFFSET_BITS. That's a scary c hange
201 # cause it affects the default length of off_t, and fpos_t, 213 # cause it affects the default length of off_t, and fpos_t,
202 # which can cause strange problems if the loading code doesn't 214 # which can cause strange problems if the loading code doesn't
203 # have it set and you start passing FILE*s or file descriptors 215 # have it set and you start passing FILE*s or file descriptors
204 # between symbol contexts. 216 # between symbol contexts.
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 ], 571 ],
560 }], 572 }],
561 ], 573 ],
562 }], 574 }],
563 ], # conditions 575 ], # conditions
564 }], 576 }],
565 ], # conditions 577 ], # conditions
566 }, 578 },
567 ], # targets 579 ], # targets
568 } 580 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698