Implement finally in new compiler.

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "vm/ast_printer.h"
 #include "vm/code_descriptors.h"
 #include "vm/dart_entry.h"
 #include "vm/flags.h"
@@ skipping 1930 matching lines @@
     if ((node->end_catch_label() != NULL) &&
         (node->end_catch_label()->join_for_continue() != NULL)) {
       if (is_open()) {
         AddInstruction(node->end_catch_label()->join_for_continue());
       } else {
         exit_ = node->end_catch_label()->join_for_continue();
       }
     }
   }
 
-  if (node->finally_block() != NULL) {
-    Bailout("EffectGraphVisitor::VisitTryCatchNode finally");
+  // Generate code for the finally block if one exists.
+  if ((node->finally_block() != NULL) && is_open()) {
+    EffectGraphVisitor for_finally_block(owner(), temp_index());
+    node->finally_block()->Visit(&for_finally_block);
+    Append(for_finally_block);
   }
 }
 
 
 void EffectGraphVisitor::BuildThrowNode(ThrowNode* node) {
   ValueGraphVisitor for_exception(owner(), temp_index());
   node->exception()->Visit(&for_exception);
   Append(for_exception);
   Instruction* instr = NULL;
   if (node->stacktrace() == NULL) {
@@ skipping 24 matching lines @@
 // A throw cannot be part of an expression, however, the parser may replace
 // certain expression nodes with a throw. In that case generate a literal null
 // so that the fragment is not closed in the middle of an expression.
 void ValueGraphVisitor::VisitThrowNode(ThrowNode* node) {
   BuildThrowNode(node);
   ReturnValue(new ConstantVal(Instance::ZoneHandle()));
 }
 
 
 void EffectGraphVisitor::VisitInlinedFinallyNode(InlinedFinallyNode* node) {
-  Bailout("EffectGraphVisitor::VisitInlinedFinallyNode");
+  const intptr_t try_index = owner()->try_index();
+  if (try_index >= 0) {
+    // We are about to generate code for an inlined finally block. Exceptions
+    // thrown in this block of code should be treated as though they are
+    // thrown not from the current try block but the outer try block if any.
+    owner()->set_try_index((try_index - 1));
+  }
+  BuildLoadContext(node->context_var(), temp_index());
+  EffectGraphVisitor for_finally_block(owner(), temp_index());
+  node->finally_block()->Visit(&for_finally_block);
+  Append(for_finally_block);
+  if (try_index >= 0) {
+    owner()->set_try_index(try_index);
+  }
 }
 
 
 // Graph printing.
 class FlowGraphPrinter : public FlowGraphVisitor {
  public:
   FlowGraphPrinter(const Function& function,
                    const GrowableArray<BlockEntryInstr*>& block_order)
       : FlowGraphVisitor(block_order), function_(function) { }
 
@@ skipping 505 matching lines @@
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len));
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart