Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 9999025: roll gtest 560:613, gmock 364:405 (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
Reviewers:
Mark Mentovai, tony
CC:
chromium-reviews
Visibility:
Public.

Description

roll gtest 560:613, gmock 364:405 Most of the included changes are minor. After this roll, we have what went into the 1.6 release, and gmock now supports being build as a DLL. (I want this roll for one of the minor changes, which makes it possible to reenable -Wnull-dereference for clang) Turn -Wnull-dereference back on, fix one instance where a violation snuck in. BUG=111806 TEST=none TBR=tony Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131656

Patch Set 1 #

Patch Set 2 : remove Wno-null-derefence #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 2 chunks +0 lines, -10 lines 0 comments Download
M webkit/support/webkit_support_gfx.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
8 years, 8 months ago (2012-04-10 17:40:47 UTC) #1
Mark Mentovai
LGTM For isolation, I would still break this up into one change to roll DEPS ...
8 years, 8 months ago (2012-04-10 17:49:25 UTC) #2
Nico
On 2012/04/10 17:49:25, Mark Mentovai wrote: > LGTM > > For isolation, I would still ...
8 years, 8 months ago (2012-04-10 17:51:42 UTC) #3
Mark Mentovai
LGTM
8 years, 8 months ago (2012-04-10 17:52:42 UTC) #4
Nico
tony: webkit/OWNERS
8 years, 8 months ago (2012-04-10 18:25:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9999025/7002
8 years, 8 months ago (2012-04-10 18:26:30 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-10 21:05:51 UTC) #7
Try job failure for 9999025-7002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698