Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9999004: Revert 131404 - Upstream native crash handling changes for Android. (Closed)

Created:
8 years, 8 months ago by msw
Modified:
8 years, 8 months ago
Reviewers:
carlosvaldivia
CC:
chromium-reviews, erikwright (departed), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 131404 - Upstream native crash handling changes for Android. Android native crash handling is almost identical to linux handling with some differences. Note that even after this change Chrome on Android will not compile with the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should remedy this state of affairs. BUG= TEST= Review URL: http://codereview.chromium.org/9838033 TBR=carlosvaldivia@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2391 lines) Patch
D base/android/build_info.h View 1 chunk +0 lines, -88 lines 0 comments Download
D base/android/build_info.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D base/android/java/org/chromium/base/BuildInfo.java View 1 chunk +0 lines, -88 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M breakpad/breakpad.gyp View 3 chunks +1 line, -150 lines 0 comments Download
M build/filename_rules.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/app/breakpad_linux.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/app/breakpad_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/breakpad_linuxish.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/app/breakpad_linuxish.cc View 1 chunk +0 lines, -1173 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/chrome_browser_main_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/chrome_content_browser_client.cc View 3 chunks +8 lines, -2 lines 0 comments Download
MM chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/crash_handler_host_linux.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/crash_handler_host_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/crash_handler_host_linux_stub.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/crash_handler_host_linuxish.h View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/crash_handler_host_linuxish.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D chrome/browser/crash_handler_host_linuxish_stub.cc View 1 chunk +0 lines, -82 lines 0 comments Download
MM chrome/browser/ui/gtk/first_run_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/chrome_browser.gypi View 3 chunks +6 lines, -8 lines 0 comments Download
MM chrome/common/logging_chrome_uitest.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
msw
8 years, 8 months ago (2012-04-09 20:10:12 UTC) #1
carlosvaldivia
8 years, 8 months ago (2012-04-09 21:05:45 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698