Optimize GetBucketContents

gpu/command_buffer/service/common_decoder.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/common_decoder.h"
 #include "gpu/command_buffer/service/cmd_buffer_engine.h"
 
 namespace gpu {
 
 CommonDecoder::Bucket::Bucket() : size_(0) {}
@@ skipping 268 matching lines @@
   Bucket* bucket = GetBucket(bucket_id);
   if (!bucket) {
     return error::kInvalidArguments;
   }
   if (!bucket->SetData(data, offset, size)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
-error::Error CommonDecoder::HandleGetBucketSize(
+error::Error CommonDecoder::HandleGetBucketStart(
     uint32 immediate_data_size,
-    const cmd::GetBucketSize& args) {
+    const cmd::GetBucketStart& args) {
   uint32 bucket_id = args.bucket_id;
-  uint32* data = GetSharedMemoryAs<uint32*>(
-      args.shared_memory_id, args.shared_memory_offset, sizeof(*data));
-  if (!data) {
+  uint32* result = GetSharedMemoryAs<uint32*>(
+      args.result_memory_id, args.result_memory_offset, sizeof(*result));
+  int32 data_memory_id = args.data_memory_id;
+  uint32 data_memory_offset = args.data_memory_offset;
+  uint32 data_memory_size = args.data_memory_size;
+  uint8* data = NULL;
+  if (data_memory_size != 0 || data_memory_id != 0 || data_memory_offset != 0) {
+    data = GetSharedMemoryAs<uint8*>(
+        args.data_memory_id, args.data_memory_offset, args.data_memory_size);
+    if (!data) {
+      return error::kInvalidArguments;
+    }
+  }
+  if (!result) {
     return error::kInvalidArguments;
   }
   // Check that the client initialized the result.
-  if (*data != 0) {
+  if (*result != 0) {
     return error::kInvalidArguments;
   }
   Bucket* bucket = GetBucket(bucket_id);
   if (!bucket) {
     return error::kInvalidArguments;
   }
-  *data = bucket->size();
+  uint32 bucket_size = bucket->size();
+  *result = bucket_size;
+  if (data) {
+    uint32 size = std::min(data_memory_size, bucket_size);
+    memcpy(data, bucket->GetData(0, size), size);
+  }
   return error::kNoError;
 }
 
 error::Error CommonDecoder::HandleGetBucketData(
     uint32 immediate_data_size,
     const cmd::GetBucketData& args) {
   uint32 bucket_id = args.bucket_id;
   uint32 offset = args.offset;
   uint32 size = args.size;
   void* data = GetSharedMemoryAs<void*>(
       args.shared_memory_id, args.shared_memory_offset, size);
   if (!data) {
     return error::kInvalidArguments;
   }
   Bucket* bucket = GetBucket(bucket_id);
   if (!bucket) {
     return error::kInvalidArguments;
   }
   const void* src = bucket->GetData(offset, size);
   if (!src) {
       return error::kInvalidArguments;
   }
   memcpy(data, src, size);
   return error::kNoError;
 }
 
 }  // namespace gpu