Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: lib/dom/scripts/systemhtml.py

Issue 9997003: Add back @domName annotations to dart:html (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: updated dom and html after sync Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/frog/dom_frog.dart ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemhtml.py
diff --git a/lib/dom/scripts/systemhtml.py b/lib/dom/scripts/systemhtml.py
index 11a0dad46d8d4d078dc4806b1a9ad65846184c4a..afcc042914302f68d500747158ac99167e3721db 100644
--- a/lib/dom/scripts/systemhtml.py
+++ b/lib/dom/scripts/systemhtml.py
@@ -671,10 +671,11 @@ class HtmlDartInterfaceGenerator(DartInterfaceGenerator):
self._EmitEventGetter(self._shared.GetParentEventsClass(self._interface))
def AddAttribute(self, getter, setter):
+ dom_name = DartDomNameOfAttribute(getter)
html_getter_name = self._shared.RenameInHtmlLibrary(
- self._interface, DartDomNameOfAttribute(getter), 'get:')
+ self._interface, dom_name, 'get:')
html_setter_name = self._shared.RenameInHtmlLibrary(
- self._interface, DartDomNameOfAttribute(getter), 'set:')
+ self._interface, dom_name, 'set:')
if not html_getter_name or self._shared.IsPrivate(html_getter_name):
getter = None
@@ -686,6 +687,9 @@ class HtmlDartInterfaceGenerator(DartInterfaceGenerator):
# We don't yet handle inconsistent renames of the getter and setter yet.
if html_getter_name and html_setter_name:
assert html_getter_name == html_setter_name
+ if html_getter_name != dom_name:
+ self._members_emitter.Emit('\n /** @domName $DOMNAME */',
+ DOMNAME = dom_name)
if (getter and setter and
DartType(getter.type.id) == DartType(setter.type.id)):
self._members_emitter.Emit('\n $TYPE $NAME;\n',
@@ -709,6 +713,10 @@ class HtmlDartInterfaceGenerator(DartInterfaceGenerator):
html_name = self._shared.RenameInHtmlLibrary(
self._interface, info.name)
if html_name and not self._shared.IsPrivate(html_name):
+ if html_name != info.name:
+ self._members_emitter.Emit('\n /** @domName $DOMNAME */',
+ DOMNAME = info.name)
+
self._members_emitter.Emit('\n'
' $TYPE $NAME($PARAMS);\n',
TYPE=info.type_name,
« no previous file with comments | « lib/dom/frog/dom_frog.dart ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698