Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4431)

Unified Diff: chrome/browser/resources/options2/options_page.js

Issue 9994005: Separate handler initialization from page initialization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: estade review Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/options_page.js
diff --git a/chrome/browser/resources/options2/options_page.js b/chrome/browser/resources/options2/options_page.js
index a4ccff7b9441b891df18ecb802d25bbf588e60f2..eadb21b73e89a5441c40577571a579ac3104bfdd 100644
--- a/chrome/browser/resources/options2/options_page.js
+++ b/chrome/browser/resources/options2/options_page.js
@@ -539,8 +539,7 @@ cr.define('options', function() {
* be invoked to do final setup.
*/
OptionsPage.initialize = function() {
- chrome.send('coreOptionsInitialize');
- this.initialized_ = true;
+ chrome.send('coreOptionsInitializePages');
uber.onContentFrameLoaded();
this.fixedHeaders_ = document.querySelectorAll('header');
@@ -637,8 +636,10 @@ cr.define('options', function() {
* finished loading).
*/
OptionsPage.reinitializeCore = function() {
Dan Beam 2012/04/05 21:38:21 And if we remove that other stuff, we can probably
- if (!this.initialized_)
- chrome.send('coreOptionsInitialize');
+ if (!this.initialized_) {
+ chrome.send('coreOptionsInitializeHandlers');
+ this.initialized_ = true;
+ }
};
OptionsPage.prototype = {

Powered by Google App Engine
This is Rietveld 408576698