chrome/browser/ui/webui/options2/password_manager_handler2.cc - Issue 9994005: Separate handler initialization from page initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options2/password_manager_handler2.cc

Issue 9994005: Separate handler initialization from page initialization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: move anything that indirectly calls JS to InitializePage Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options2/password_manager_handler2.cc

diff --git a/chrome/browser/ui/webui/options2/password_manager_handler2.cc b/chrome/browser/ui/webui/options2/password_manager_handler2.cc

index 31d32bf3d23854b440fc0da988ac4af8efbd3b72..550ce81c6031b6b4976a1acff72b8df0b07549a8 100644

--- a/chrome/browser/ui/webui/options2/password_manager_handler2.cc

+++ b/chrome/browser/ui/webui/options2/password_manager_handler2.cc

@@ -77,7 +77,7 @@ void PasswordManagerHandler::GetLocalizedValues(

chrome::kPasswordManagerLearnMoreURL);

}

-void PasswordManagerHandler::InitializeHandler() {

+void PasswordManagerHandler::InitializePage() {

// Due to the way that handlers are (re)initialized under certain types of

// navigation, we may already be initialized. (See bugs 88986 and 86448.)

// If this is the case, return immediately. This is a hack.