Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9311)

Unified Diff: chrome/browser/ui/webui/options2/options_ui2.h

Issue 9994005: Separate handler initialization from page initialization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move anything that indirectly calls JS to InitializePage Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/options_ui2.h
diff --git a/chrome/browser/ui/webui/options2/options_ui2.h b/chrome/browser/ui/webui/options2/options_ui2.h
index 09faebefe7328a1d145a7121234aad53f9e775d0..4ca6a6ab594f76edf3b2824fe81c252aed972a15 100644
--- a/chrome/browser/ui/webui/options2/options_ui2.h
+++ b/chrome/browser/ui/webui/options2/options_ui2.h
@@ -91,7 +91,7 @@ class OptionsPageUIHandler : public content::WebUIMessageHandler,
// should provide.
class OptionsPageUIHandlerHost {
public:
- virtual void InitializeHandlers() = 0;
+ virtual void InitializePages() = 0;
protected:
virtual ~OptionsPageUIHandlerHost() {}
@@ -117,10 +117,9 @@ class OptionsUI : public content::WebUIController,
content::RenderViewHost* render_view_host) OVERRIDE;
virtual void RenderViewReused(
content::RenderViewHost* render_view_host) OVERRIDE;
- virtual void DidBecomeActiveForReusedRenderView() OVERRIDE;
// Overridden from OptionsPageUIHandlerHost:
- virtual void InitializeHandlers() OVERRIDE;
+ virtual void InitializePages() OVERRIDE;
private:
// Adds OptionsPageUiHandler to the handlers list if handler is enabled.
@@ -131,8 +130,6 @@ class OptionsUI : public content::WebUIController,
// launching chrome.
void SetCommandLineString(content::RenderViewHost* render_view_host);
- bool initialized_handlers_;
-
std::vector<OptionsPageUIHandler*> handlers_;
#if defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698