chrome/browser/ui/webui/options2/handler_options_handler2.cc - Issue 9994005: Separate handler initialization from page initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options2/handler_options_handler2.cc

Issue 9994005: Separate handler initialization from page initialization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: move anything that indirectly calls JS to InitializePage Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options2/handler_options_handler2.cc

diff --git a/chrome/browser/ui/webui/options2/handler_options_handler2.cc b/chrome/browser/ui/webui/options2/handler_options_handler2.cc

index 0696b76b70302821bd81be49e0e8e05299e553bb..6266d99fe4f5122eede6c25a0985b06de4a705a5 100644

--- a/chrome/browser/ui/webui/options2/handler_options_handler2.cc

+++ b/chrome/browser/ui/webui/options2/handler_options_handler2.cc

@@ -45,13 +45,10 @@ void HandlerOptionsHandler::GetLocalizedValues(

RegisterStrings(localized_strings, resources, arraysize(resources));

}

-void HandlerOptionsHandler::InitializeHandler() {

+void HandlerOptionsHandler::InitializePage() {

notification_registrar_.Add(

this, chrome::NOTIFICATION_PROTOCOL_HANDLER_REGISTRY_CHANGED,

content::Source<Profile>(Profile::FromWebUI(web_ui())));

-void HandlerOptionsHandler::InitializePage() {

UpdateHandlerList();

}