Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4957)

Unified Diff: chrome/browser/ui/webui/options2/core_options_handler2.h

Issue 9994005: Separate handler initialization from page initialization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move anything that indirectly calls JS to InitializePage Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/core_options_handler2.h
diff --git a/chrome/browser/ui/webui/options2/core_options_handler2.h b/chrome/browser/ui/webui/options2/core_options_handler2.h
index 8849a6ab77ec3d0f88f162597fd4fb69cd2ddc08..48b110ec087817d9f2c4b54d19514e3a55a0a9c7 100644
--- a/chrome/browser/ui/webui/options2/core_options_handler2.h
+++ b/chrome/browser/ui/webui/options2/core_options_handler2.h
@@ -26,7 +26,6 @@ class CoreOptionsHandler : public OptionsPageUIHandler {
// OptionsPageUIHandler implementation.
virtual void GetLocalizedValues(DictionaryValue* localized_strings) OVERRIDE;
- virtual void InitializeHandler() OVERRIDE;
virtual void InitializePage() OVERRIDE;
virtual void Uninitialize() OVERRIDE;
@@ -98,10 +97,10 @@ class CoreOptionsHandler : public OptionsPageUIHandler {
TYPE_LIST,
};
- // Callback for the "coreOptionsInitialize" message. This message will
- // trigger the Initialize() method of all other handlers so that final
- // setup can be performed before the page is shown.
- void HandleInitialize(const ListValue* args);
+ // Callback for the "coreOptionsInitializePages" message. This calls the
+ // InitializePage() method of all other handlers, to pass data back to the
+ // JavaScript on the page so it can populate the UI.
+ void HandleInitializePages(const ListValue* args);
// Callback for the "fetchPrefs" message. This message accepts the list of
// preference names passed as the |args| parameter (ListValue). It passes

Powered by Google App Engine
This is Rietveld 408576698