Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3951)

Unified Diff: chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc

Issue 9994005: Separate handler initialization from page initialization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move anything that indirectly calls JS to InitializePage Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc
diff --git a/chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc b/chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc
index 06ba4fba11e5c05754ece7787227e8412d7ad118..4ca0244d88cd5961a1fcc132dfb71faa1dbc160d 100644
--- a/chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc
+++ b/chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc
@@ -112,7 +112,7 @@ CoreChromeOSOptionsHandler::~CoreChromeOSOptionsHandler() {
pointer_factory_.GetWeakPtr()));
}
-void CoreChromeOSOptionsHandler::InitializeHandler() {
+void CoreChromeOSOptionsHandler::InitializePage() {
proxy_prefs_.reset(PrefSetObserver::CreateProxyPrefSetObserver(
Profile::FromWebUI(web_ui())->GetPrefs(), this));
// Observe the chromeos::ProxyConfigServiceImpl for changes from the UI.
@@ -123,11 +123,6 @@ void CoreChromeOSOptionsHandler::InitializeHandler() {
pointer_factory_.GetWeakPtr()));
}
-void CoreChromeOSOptionsHandler::InitializePage() {
- // NOTE: Don't remove this, we're intentionally ignoring the base class'
- // implementation of InitializePage.
-}
-
base::Value* CoreChromeOSOptionsHandler::FetchPref(
const std::string& pref_name) {
if (proxy_cros_settings_parser::IsProxyPref(pref_name)) {

Powered by Google App Engine
This is Rietveld 408576698