Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/ui/webui/options2/core_options_handler2.cc

Issue 9994005: Separate handler initialization from page initialization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: estade review Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options2/core_options_handler2.h" 5 #include "chrome/browser/ui/webui/options2/core_options_handler2.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/json/json_reader.h" 9 #include "base/json/json_reader.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 UpdateClearPluginLSOData(); 127 UpdateClearPluginLSOData();
128 return; 128 return;
129 } 129 }
130 NotifyPrefChanged(*pref_name, std::string()); 130 NotifyPrefChanged(*pref_name, std::string());
131 } 131 }
132 } 132 }
133 133
134 void CoreOptionsHandler::RegisterMessages() { 134 void CoreOptionsHandler::RegisterMessages() {
135 registrar_.Init(Profile::FromWebUI(web_ui())->GetPrefs()); 135 registrar_.Init(Profile::FromWebUI(web_ui())->GetPrefs());
136 136
137 web_ui()->RegisterMessageCallback("coreOptionsInitialize", 137 web_ui()->RegisterMessageCallback("coreOptionsInitializeHandlers",
138 base::Bind(&CoreOptionsHandler::HandleInitialize, 138 base::Bind(&CoreOptionsHandler::HandleInitializeHandlers,
139 base::Unretained(this)));
140 web_ui()->RegisterMessageCallback("coreOptionsInitializePages",
141 base::Bind(&CoreOptionsHandler::HandleInitializePages,
139 base::Unretained(this))); 142 base::Unretained(this)));
140 web_ui()->RegisterMessageCallback("fetchPrefs", 143 web_ui()->RegisterMessageCallback("fetchPrefs",
141 base::Bind(&CoreOptionsHandler::HandleFetchPrefs, 144 base::Bind(&CoreOptionsHandler::HandleFetchPrefs,
142 base::Unretained(this))); 145 base::Unretained(this)));
143 web_ui()->RegisterMessageCallback("observePrefs", 146 web_ui()->RegisterMessageCallback("observePrefs",
144 base::Bind(&CoreOptionsHandler::HandleObservePrefs, 147 base::Bind(&CoreOptionsHandler::HandleObservePrefs,
145 base::Unretained(this))); 148 base::Unretained(this)));
146 web_ui()->RegisterMessageCallback("setBooleanPref", 149 web_ui()->RegisterMessageCallback("setBooleanPref",
147 base::Bind(&CoreOptionsHandler::HandleSetBooleanPref, 150 base::Bind(&CoreOptionsHandler::HandleSetBooleanPref,
148 base::Unretained(this))); 151 base::Unretained(this)));
(...skipping 13 matching lines...) Expand all
162 base::Bind(&CoreOptionsHandler::HandleSetListPref, 165 base::Bind(&CoreOptionsHandler::HandleSetListPref,
163 base::Unretained(this))); 166 base::Unretained(this)));
164 web_ui()->RegisterMessageCallback("clearPref", 167 web_ui()->RegisterMessageCallback("clearPref",
165 base::Bind(&CoreOptionsHandler::HandleClearPref, 168 base::Bind(&CoreOptionsHandler::HandleClearPref,
166 base::Unretained(this))); 169 base::Unretained(this)));
167 web_ui()->RegisterMessageCallback("coreOptionsUserMetricsAction", 170 web_ui()->RegisterMessageCallback("coreOptionsUserMetricsAction",
168 base::Bind(&CoreOptionsHandler::HandleUserMetricsAction, 171 base::Bind(&CoreOptionsHandler::HandleUserMetricsAction,
169 base::Unretained(this))); 172 base::Unretained(this)));
170 } 173 }
171 174
172 void CoreOptionsHandler::HandleInitialize(const ListValue* args) { 175 void CoreOptionsHandler::HandleInitializeHandlers(const ListValue* args) {
173 DCHECK(handlers_host_); 176 DCHECK(handlers_host_);
174 handlers_host_->InitializeHandlers(); 177 handlers_host_->InitializeHandlers();
175 } 178 }
176 179
180 void CoreOptionsHandler::HandleInitializePages(const ListValue* args) {
181 DCHECK(handlers_host_);
182 handlers_host_->InitializePages();
183 }
184
177 base::Value* CoreOptionsHandler::FetchPref(const std::string& pref_name) { 185 base::Value* CoreOptionsHandler::FetchPref(const std::string& pref_name) {
178 PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs(); 186 PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
179 187
180 const PrefService::Preference* pref = 188 const PrefService::Preference* pref =
181 pref_service->FindPreference(pref_name.c_str()); 189 pref_service->FindPreference(pref_name.c_str());
182 if (!pref) 190 if (!pref)
183 return base::Value::CreateNullValue(); 191 return base::Value::CreateNullValue();
184 192
185 return CreateValueForPref(pref, NULL); 193 return CreateValueForPref(pref, NULL);
186 } 194 }
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 465
458 void CoreOptionsHandler::UpdateClearPluginLSOData() { 466 void CoreOptionsHandler::UpdateClearPluginLSOData() {
459 scoped_ptr<base::Value> enabled( 467 scoped_ptr<base::Value> enabled(
460 base::Value::CreateBooleanValue( 468 base::Value::CreateBooleanValue(
461 clear_plugin_lso_data_enabled_.GetValue())); 469 clear_plugin_lso_data_enabled_.GetValue()));
462 web_ui()->CallJavascriptFunction( 470 web_ui()->CallJavascriptFunction(
463 "OptionsPage.setClearPluginLSODataEnabled", *enabled); 471 "OptionsPage.setClearPluginLSODataEnabled", *enabled);
464 } 472 }
465 473
466 } // namespace options2 474 } // namespace options2
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698