Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/webui/options2/handler_options_handler2.h

Issue 9994005: Separate handler initialization from page initialization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move anything that indirectly calls JS to InitializePage Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS2_HANDLER_OPTIONS_HANDLER2_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS2_HANDLER_OPTIONS_HANDLER2_H_
6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS2_HANDLER_OPTIONS_HANDLER2_H_ 6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS2_HANDLER_OPTIONS_HANDLER2_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "chrome/browser/custom_handlers/protocol_handler_registry.h" 10 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
(...skipping 15 matching lines...) Expand all
26 namespace options2 { 26 namespace options2 {
27 27
28 class HandlerOptionsHandler : public OptionsPageUIHandler { 28 class HandlerOptionsHandler : public OptionsPageUIHandler {
29 public: 29 public:
30 HandlerOptionsHandler(); 30 HandlerOptionsHandler();
31 virtual ~HandlerOptionsHandler(); 31 virtual ~HandlerOptionsHandler();
32 32
33 // OptionsPageUIHandler implementation. 33 // OptionsPageUIHandler implementation.
34 virtual void GetLocalizedValues( 34 virtual void GetLocalizedValues(
35 base::DictionaryValue* localized_strings) OVERRIDE; 35 base::DictionaryValue* localized_strings) OVERRIDE;
36 virtual void InitializeHandler() OVERRIDE;
37 virtual void InitializePage() OVERRIDE; 36 virtual void InitializePage() OVERRIDE;
38 virtual void RegisterMessages() OVERRIDE; 37 virtual void RegisterMessages() OVERRIDE;
39 38
40 // content::NotificationObserver implementation. 39 // content::NotificationObserver implementation.
41 virtual void Observe(int type, 40 virtual void Observe(int type,
42 const content::NotificationSource& source, 41 const content::NotificationSource& source,
43 const content::NotificationDetails& details) OVERRIDE; 42 const content::NotificationDetails& details) OVERRIDE;
44 43
45 private: 44 private:
46 // Called when the user toggles whether custom handlers are enabled. 45 // Called when the user toggles whether custom handlers are enabled.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 ProtocolHandlerRegistry* GetProtocolHandlerRegistry(); 78 ProtocolHandlerRegistry* GetProtocolHandlerRegistry();
80 79
81 content::NotificationRegistrar notification_registrar_; 80 content::NotificationRegistrar notification_registrar_;
82 81
83 DISALLOW_COPY_AND_ASSIGN(HandlerOptionsHandler); 82 DISALLOW_COPY_AND_ASSIGN(HandlerOptionsHandler);
84 }; 83 };
85 84
86 } // namespace options2 85 } // namespace options2
87 86
88 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS2_HANDLER_OPTIONS_HANDLER2_H_ 87 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS2_HANDLER_OPTIONS_HANDLER2_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698