Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 9985010: Fix issues when stressing compaction with WeakMaps. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issues when stressing compaction with WeakMaps. 1) While marking the backing hash table of a WeakMap we also need to record the slot because it might be on an evacuation candidate. 2) With incremental marking one backing hash table might be marked more than once because the WeakMap might have gone through a white to gray transition. 3) The corner case when the allocation of the backing hash table itself causes a GC, leads to a WeakMap with an undefined table field, so we still need to handle this case correctly. R=vegorov@chromium.org TEST=mjsunit/harmony/proxies-example-membrane --stress-compaction Committed: https://code.google.com/p/v8/source/detail?r=11385

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M src/mark-compact.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 8 months ago (2012-04-19 09:33:40 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 8 months ago (2012-04-19 10:25:43 UTC) #2
lgtm

lgtm

https://chromiumcodereview.appspot.com/9985010/diff/1/test/cctest/test-weakma...
File test/cctest/test-weakmaps.cc (right):

https://chromiumcodereview.appspot.com/9985010/diff/1/test/cctest/test-weakma...
test/cctest/test-weakmaps.cc:68: FLAG_incremental_marking = false;
do we want some sort of todo referencing an issue here?

Powered by Google App Engine
This is Rietveld 408576698